Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 250783002: net: Make sure the FileStream file is closed on the worker thread. (Closed)

Created:
6 years, 8 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

net: Make sure the FileStream file is closed on the worker thread. When a FileStream is deleted while Open is in progress, the file was being closed on the wrong thread because it was not being transferred to the FileStream::Context. This CL transfers the file to the context even if it is orphaned. BUG=322664 TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267977

Patch Set 1 #

Patch Set 2 : Use an explicit worker pool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M net/base/file_stream_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/file_stream_unittest.cc View 1 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rvargas (doing something else)
PTAL
6 years, 8 months ago (2014-04-25 21:17:54 UTC) #1
rvargas (doing something else)
On 2014/04/25 21:17:54, rvargas wrote: > PTAL ping
6 years, 7 months ago (2014-04-30 23:50:49 UTC) #2
willchan no longer on Chromium
lgtm
6 years, 7 months ago (2014-05-02 19:44:58 UTC) #3
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-02 20:09:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/250783002/20001
6 years, 7 months ago (2014-05-02 20:10:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:54:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:54:21 UTC) #7
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-02 21:44:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/250783002/20001
6 years, 7 months ago (2014-05-02 21:44:41 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:59:02 UTC) #10
Message was sent while issue was closed.
Change committed as 267977

Powered by Google App Engine
This is Rietveld 408576698