Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2507823002: Remove now-renamed java targets (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
Yusuf, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, agrieve+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now-renamed java targets This is the third side of the three-sided patch. BUG=620034 Committed: https://crrev.com/3e2ea8b9d7313098049c5cee3496798e05f4318a Cr-Commit-Position: refs/heads/master@{#432588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/java/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/custom_tabs_client/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
agrieve
🐾
4 years, 1 month ago (2016-11-16 15:47:24 UTC) #2
yzshen1
lgtm
4 years, 1 month ago (2016-11-16 19:00:42 UTC) #8
Yusuf
lgtm
4 years, 1 month ago (2016-11-16 19:02:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507823002/1
4 years, 1 month ago (2016-11-16 19:19:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 19:29:07 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e2ea8b9d7313098049c5cee3496798e05f4318a
Cr-Commit-Position: refs/heads/master@{#432588}

Powered by Google App Engine
This is Rietveld 408576698