Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc

Issue 2507813003: Periodically remove old pending navigation entries.
Patch Set: Sync Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6accdd2c4a74bab9daa305380ca5f31b50e9858a
--- /dev/null
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
@@ -0,0 +1,106 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/data_use_measurement/chrome_data_use_ascriber.h"
+
+#include <list>
+#include <memory>
+#include <string>
+
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "components/data_use_measurement/core/data_use_recorder.h"
+#include "content/public/browser/resource_request_info.h"
+#include "content/public/common/browser_side_navigation_policy.h"
+#include "content/public/common/process_type.h"
+#include "content/public/test/mock_resource_context.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "ipc/ipc_message.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+int kRenderProcessId = 1;
+int kRenderFrameId = 2;
+int kRequestId = 3;
+}
+
+namespace data_use_measurement {
+
+class ChromeDataUseAscriberTest : public testing::Test {
+ protected:
+ ChromeDataUseAscriberTest()
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+ resource_context_(new content::MockResourceContext(&context_)) {}
+
+ void DeleteOldPendingNavigationEntries(base::Time now) {
+ ascriber_.DeleteOldPendingNavigationEntries(now);
+ }
+
+ std::list<std::unique_ptr<DataUseRecorder>>& recorders() {
+ return ascriber_.data_use_recorders_;
+ }
+
+ net::TestURLRequestContext* context() { return &context_; }
+
+ content::MockResourceContext* resource_context() {
+ return resource_context_.get();
+ }
+
+ ChromeDataUseAscriber* ascriber() { return &ascriber_; }
+
+ std::unique_ptr<net::URLRequest> CreateNewRequest(std::string url,
+ bool is_main_frame,
+ int request_id,
+ int render_process_id,
+ int render_frame_id) {
+ std::unique_ptr<net::URLRequest> request =
+ context()->CreateRequest(GURL(url), net::IDLE, nullptr);
+
+ content::ResourceRequestInfo::AllocateForTesting(
+ request.get(),
+ is_main_frame ? content::RESOURCE_TYPE_MAIN_FRAME :
+ content::RESOURCE_TYPE_SUB_RESOURCE,
+ resource_context(),
+ kRenderProcessId,
+ MSG_ROUTING_NONE,
+ kRenderFrameId,
+ is_main_frame,
+ false, // parent_is_main_frame
+ false, // allow_download
+ true, // is_async
+ false); // is_using_lofi
+
+ return request;
+ }
+
+ private:
+ content::TestBrowserThreadBundle thread_bundle_;
+ ChromeDataUseAscriber ascriber_;
+ net::TestURLRequestContext context_;
+ std::unique_ptr<content::MockResourceContext> resource_context_;
+};
+
+TEST_F(ChromeDataUseAscriberTest, DeleteOldPendingNavigationEntries) {
+ if (content::IsBrowserSideNavigationEnabled())
+ return;
+
+ std::unique_ptr<net::URLRequest> request = CreateNewRequest(
+ "http://test.com", true, kRequestId, kRenderProcessId, kRenderFrameId);
+
+ ascriber()->RenderFrameCreated(kRenderProcessId, kRenderFrameId, -1, -1);
+ ascriber()->OnBeforeUrlRequest(request.get());
+ EXPECT_EQ(2u, recorders().size());
+
+ ascriber()->RenderFrameDeleted(kRenderProcessId, kRenderFrameId, -1, -1);
+ DeleteOldPendingNavigationEntries(base::Time::Now() +
+ base::TimeDelta::FromSeconds(4));
+ EXPECT_EQ(1u, recorders().size());
+
+ DeleteOldPendingNavigationEntries(base::Time::Now() +
+ base::TimeDelta::FromSeconds(5));
+ EXPECT_EQ(0u, recorders().size());
+}
+
+} // namespace data_use_measurement
« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698