Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2507813003: Periodically remove old pending navigation entries.

Created:
4 years, 1 month ago by Not at Google. Contact bengr
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Periodically remove old pending navigation entries. The ReadyToCommitNavigation() callback is used to remove entries from |pending_navigation_data_use_map_|. However, there are a number of race conditions which make this callback unreliable until PlzNavigate is used. This cl periodically deletes navigation entries older than a threshold that have finished data use. BUG=660065

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -3 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 1 4 chunks +34 lines, -2 lines 0 comments Download
A chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 18 (18 generated)
Not at Google. Contact bengr
The CQ bit was checked by kundaji@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-16 23:54:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507813003/1
4 years, 1 month ago (2016-11-16 23:55:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-17 00:35:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/262425) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 1 month ago (2016-11-17 00:35:22 UTC) #4
Not at Google. Contact bengr
The CQ bit was checked by kundaji@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-17 16:56:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507813003/20001
4 years, 1 month ago (2016-11-17 16:57:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-17 18:12:49 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/182871)
4 years, 1 month ago (2016-11-17 18:12:50 UTC) #8
Not at Google. Contact bengr
The CQ bit was checked by kundaji@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-17 21:21:14 UTC) #9
Not at Google. Contact bengr
Patchset #2 (id:20001) has been deleted
4 years, 1 month ago (2016-11-17 21:21:40 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507813003/40001
4 years, 1 month ago (2016-11-17 21:22:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-17 21:29:22 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/109131)
4 years, 1 month ago (2016-11-17 21:29:23 UTC) #13
Not at Google. Contact bengr
Patchset #2 (id:40001) has been deleted
4 years, 1 month ago (2016-11-17 21:37:53 UTC) #14
Not at Google. Contact bengr
The CQ bit was checked by kundaji@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-17 21:38:19 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507813003/60001
4 years, 1 month ago (2016-11-17 21:39:48 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-18 00:55:26 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 00:55:27 UTC) #18
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698