Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Unified Diff: chrome/browser/ntp_snippets/download_suggestions_provider.cc

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)
Patch Set: removed TODO. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ntp_snippets/download_suggestions_provider.cc
diff --git a/chrome/browser/ntp_snippets/download_suggestions_provider.cc b/chrome/browser/ntp_snippets/download_suggestions_provider.cc
index c5ef7dda97185091978abecbf1b093c809bb452e..332dfeb93bc242d2da83b31f3630949f365b95b0 100644
--- a/chrome/browser/ntp_snippets/download_suggestions_provider.cc
+++ b/chrome/browser/ntp_snippets/download_suggestions_provider.cc
@@ -488,6 +488,7 @@ ContentSuggestion DownloadSuggestionsProvider::ConvertOfflinePage(
suggestion.set_publisher_name(base::UTF8ToUTF16(offline_page.url.host()));
auto extra = base::MakeUnique<ntp_snippets::DownloadSuggestionExtra>();
extra->is_download_asset = false;
+ extra->offline_page_id = base::Int64ToString(offline_page.offline_id);
Marc Treib 2016/11/16 15:22:58 Er, any reason why we pass this as a string? Seems
vitaliii 2016/11/16 15:45:08 As we discussed it is not clear how to match int64
Marc Treib 2016/11/16 15:55:56 There's a jlong analogous to jint, I'm pretty sure
vitaliii 2016/11/16 15:59:23 Acknowledged.
suggestion.set_download_suggestion_extra(std::move(extra));
return suggestion;
}

Powered by Google App Engine
This is Rietveld 408576698