chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)

Patch Set: removed TODO. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | chrome/browser/ntp_snippets/download_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 9658d36b5f3f0ac5def4b5ea479014e94f2f31ef..ed7bbe87694deec3975267d6f014eaadfa1a68d3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -217,6 +217,13 @@ public class SnippetsBridge implements SuggestionsSource {

}

@CalledByNative

+ private static void setDownloadOfflinePageDataForLastSuggestion(

+ List<SnippetArticle> suggestions, String offlinePageId) {

+ assert suggestions.size() > 0;

+ suggestions.get(suggestions.size() - 1).setDownloadOfflinePageData(offlinePageId);

+ }

+ @CalledByNative

private static void setRecentTabDataForLastSuggestion(

List<SnippetArticle> suggestions, String tabId, String offlinePageId) {

assert suggestions.size() > 0;