Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4630)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 2507753002: Install the chrome event log provider together with the browser. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index e966cb74d14484a49d7178e7db4f23e47402702f..6c34c5087ef518195df54e5bffb87cb057daf0ec 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -1225,10 +1225,18 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
// Delete media player registry key that exists only in HKLM.
// We don't delete this key in SxS uninstall or Chrome Frame uninstall
// as we never set the key for those products.
- base::string16 reg_path(installer::kMediaPlayerRegPath);
- reg_path.push_back(base::FilePath::kSeparators[0]);
- reg_path.append(installer::kChromeExe);
- InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, reg_path,
+ base::string16 media_player_reg_path(installer::kMediaPlayerRegPath);
grt (UTC plus 2) 2016/11/16 15:04:44 personal preference: i would keep this as reg_path
pastarmovj 2016/11/17 15:34:43 Done.
+ media_player_reg_path.push_back(base::FilePath::kSeparators[0]);
+ media_player_reg_path.append(installer::kChromeExe);
+ InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, media_player_reg_path,
+ WorkItem::kWow64Default);
+ // Remove the event log provider registration as we are going to delete
grt (UTC plus 2) 2016/11/16 15:04:44 nit: blank line before this
pastarmovj 2016/11/17 15:34:43 Done.
+ // the file which serves the resources anyways.
+ base::string16 eventlog_reg_path(installer::kEventlogProvidersRegPath);
+ // registry paths can also be appended like file system path
+ eventlog_reg_path.push_back(base::FilePath::kSeparators[0]);
+ eventlog_reg_path.append(installer::kChromeEventLogProviderName);
+ InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, eventlog_reg_path,
WorkItem::kWow64Default);
}
« chrome/installer/setup/setup_constants.h ('K') | « chrome/installer/setup/setup_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698