Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5559)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 2507753002: Install the chrome event log provider together with the browser. (Closed)
Patch Set: Fix wrong append call. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 3365f2a0b7bb852b8270d081a74cb0d67bc125bf..66717708e20d25eaaa129914ec16dd207039e0d1 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -1230,6 +1230,10 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
reg_path.append(installer::kChromeExe);
InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, reg_path,
WorkItem::kWow64Default);
+
+ // Remove the event log provider registration as we are going to delete
+ // the file which serves the resources anyways.
+ DeRegisterEventLogProvider();
grt (UTC plus 2) 2016/11/22 10:41:26 could you try uninstalling while eventvwr is showi
pastarmovj 2016/11/23 14:27:26 I checked that actually - the file is indeed held
}
// Unregister any dll servers that we may have registered for this

Powered by Google App Engine
This is Rietveld 408576698