Install the chrome event log provider together with the browser.

chrome/installer/setup/setup_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares util functions for setup project.
 
 #include "chrome/installer/setup/setup_util.h"
 
 #include <windows.h>
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
+#include <limits>
+#include <memory>
 #include <set>
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/version.h"
 #include "base/win/registry.h"
 #include "base/win/windows_version.h"
 #include "chrome/installer/setup/installer_state.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/setup/user_hive_visitor.h"
 #include "chrome/installer/util/app_registration_data.h"
 #include "chrome/installer/util/google_update_constants.h"
+#include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/installation_state.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/master_preferences_constants.h"
 #include "chrome/installer/util/util_constants.h"
 #include "courgette/courgette.h"
 #include "courgette/third_party/bsdiff/bsdiff.h"
 
 namespace installer {
 
 namespace {
 
+// Event log provider registry location and value names.
+constexpr wchar_t kEventLogProvidersRegPath[] =

[grt (UTC plus 2), 2016/11/18 11:38:12]

nit: kEventLogProviderRegPath

[pastarmovj, 2016/11/21 15:48:40]

Done.

+    L"\\SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\chrome";

[grt (UTC plus 2), 2016/11/18 11:38:12]

can "chrome" be any string, or does it need to be "chrome"? as-is, multiple
installs will collide in this registry key (i.e., stable, dev, beta), as will
Chromium.

[grt (UTC plus 2), 2016/11/18 12:10:34]

Maybe use BrowserDistribution::GetBaseAppName() for the last component of this
path? It returns something different for each install.

[pastarmovj, 2016/11/21 15:48:40]

Unfortunately this has to coincide with the costant kEventSource defined here
https://cs.chromium.org/chromium/src/base/syslog_logging.cc?rcl=0&l=28 which is
in base and therefore would not be suitable to depend on other components. I
think however this is not a big deal since worst case a degraded UI experience
in the Event Viewer will appear but no crashes or anything will happen. 

[grt (UTC plus 2), 2016/11/22 10:41:25]

ah, this is pretty bad. any Chromium-based browser co-installed with Google
Chrome will use Chrome's log provider dll. i think we can do better. you could
introduce a function in logging:: to set the event source name, and then call it
from within Chrome somewhere after Chrome figures out which channel it is. each
Chrome channel should have its own event source name. it would be natural to add
the event source name to install_static/install_constants.h, and then in
chromium_install_modes.cc and google_chrome_install_modes.cc. you would then add
an accessor for it to InstallDetails (a la app_guid()). InitChromeLogging could
then set the event source name with something like:

 
logging::SetEventSourceName(install_static::InstallDetails::Get().event_source_name());

this scales better across multiple distributions. the installer can't use this
part of install_static until i land https://codereview.chromium.org/2459583002/,
so you would have to be a little hacky in here for now. add a TODO(grt) to clean
it up.

[grt (UTC plus 2), 2016/11/24 07:49:34]

Also anything else built using Chromium's base, which is a growing body of
software (CEF and whatnot).

+
 // Returns true if product |type| cam be meaningfully installed without the
 // --multi-install flag.
 bool SupportsSingleInstall(BrowserDistribution::Type type) {
   return (type == BrowserDistribution::CHROME_BROWSER ||
           type == BrowserDistribution::CHROME_FRAME);
 }
 
 // Returns true if the "lastrun" value in |root|\|key_path| (a path to Chrome's
 // ClientState key for a user) indicates that Chrome has been used within the
 // last 28 days.
@@ skipping 593 matching lines @@
       UNPACK_STATUS_COUNT, UNPACK_STATUS_COUNT + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->Add(unpack_status);
 
   base::SparseHistogram::FactoryGet(
       std::string(kUnPackNTSTATUSMetricsName) + "_" + consumer_name,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->Add(status);
 }
 
+void RegisterEventLogProvider(const base::FilePath& chrome_exe) {
+  VLOG(1) << "Registering Chrome's event log provider at "
+          << kEventLogProvidersRegPath;
+
+  std::unique_ptr<WorkItemList> work_item_list(WorkItem::CreateWorkItemList());
+
+  work_item_list->AddCreateRegKeyWorkItem(
+      HKEY_LOCAL_MACHINE, kEventLogProvidersRegPath, WorkItem::kWow64Default);
+  work_item_list->AddSetRegValueWorkItem(
+      HKEY_LOCAL_MACHINE, kEventLogProvidersRegPath, WorkItem::kWow64Default,
+      L"CategoryCount", static_cast<DWORD>(1), true);
+  work_item_list->AddSetRegValueWorkItem(

[grt (UTC plus 2), 2016/11/18 11:38:12]

nit: could you put a simple comment above each of these explaining what they
accomplish? what does "7" mean?

[pastarmovj, 2016/11/21 15:48:40]

Done.

+      HKEY_LOCAL_MACHINE, kEventLogProvidersRegPath, WorkItem::kWow64Default,
+      L"TypesSupported", static_cast<DWORD>(7), true);
+
+  base::FilePath provider(chrome_exe.DirName());
+  provider.Append(FILE_PATH_LITERAL("eventlog_provider.dll"));

[grt (UTC plus 2), 2016/11/18 11:38:12]

the provider is in the version directory, so you need to Append the version #
being installed, no? i think all callers of RegisterChromeOnMachine know the
version, so you could pass it on down into here.

[pastarmovj, 2016/11/21 15:48:40]

Done.

+
+  static constexpr wchar_t* file_keys[] = {
+      L"CategoryMessageFile",
+      L"EventMessageFile",
+      L"ParameterMessageFile",
+  };
+  for (const wchar_t* file_key : file_keys) {
+    work_item_list->AddSetRegValueWorkItem(
+        HKEY_LOCAL_MACHINE, kEventLogProvidersRegPath, WorkItem::kWow64Default,
+        file_key, provider.value(), true);
+  }
+
+  // if the operation fails we log the error but still continue because none of
+  // these are critical for the proper operation of the browser.
+  if (!work_item_list->Do())

[grt (UTC plus 2), 2016/11/18 11:38:12]

are you intentionally not calling Rollback? if so, please explain why in the
comment above. or is that what you're trying to convey in the comment?

[pastarmovj, 2016/11/21 15:48:41]

No sorry I mistakenly assumed that the rollback is the default behavior but now
I read what you were telling me is that I can change the default on a task by
task basis not that it will magically happen for the list.

+    LOG(ERROR) << "Could not register Chrome's event log provider.";
+}
+
+void DeRegisterEventLogProvider() {
+  InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, kEventLogProvidersRegPath,
+                                 WorkItem::kWow64Default);
+}
+
 ScopedTokenPrivilege::ScopedTokenPrivilege(const wchar_t* privilege_name)
     : is_enabled_(false) {
   HANDLE temp_handle;
   if (!::OpenProcessToken(::GetCurrentProcess(),
                           TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY,
                           &temp_handle)) {
     return;
   }
   token_.Set(temp_handle);
 
@@ skipping 22 matching lines @@
 }
 
 ScopedTokenPrivilege::~ScopedTokenPrivilege() {
   if (is_enabled_ && previous_privileges_.PrivilegeCount != 0) {
     ::AdjustTokenPrivileges(token_.Get(), FALSE, &previous_privileges_,
                             sizeof(TOKEN_PRIVILEGES), NULL, NULL);
   }
 }
 
 }  // namespace installer