Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/installer/setup/setup_util.cc

Issue 2507753002: Install the chrome event log provider together with the browser. (Closed)
Patch Set: Address comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares util functions for setup project. 5 // This file declares util functions for setup project.
6 6
7 #include "chrome/installer/setup/setup_util.h" 7 #include "chrome/installer/setup/setup_util.h"
8 8
9 #include <windows.h> 9 #include <windows.h>
10 #include <stddef.h> 10 #include <stddef.h>
11 11
12 #include <algorithm> 12 #include <algorithm>
13 #include <iterator> 13 #include <iterator>
14 #include <limits>
15 #include <memory>
14 #include <set> 16 #include <set>
15 #include <string> 17 #include <string>
16 18
17 #include "base/bind.h" 19 #include "base/bind.h"
18 #include "base/command_line.h" 20 #include "base/command_line.h"
19 #include "base/cpu.h" 21 #include "base/cpu.h"
20 #include "base/files/file_enumerator.h" 22 #include "base/files/file_enumerator.h"
21 #include "base/files/file_path.h" 23 #include "base/files/file_path.h"
22 #include "base/files/file_util.h" 24 #include "base/files/file_util.h"
23 #include "base/logging.h" 25 #include "base/logging.h"
24 #include "base/macros.h" 26 #include "base/macros.h"
25 #include "base/metrics/histogram.h" 27 #include "base/metrics/histogram.h"
26 #include "base/numerics/safe_conversions.h" 28 #include "base/numerics/safe_conversions.h"
27 #include "base/strings/string_number_conversions.h" 29 #include "base/strings/string_number_conversions.h"
28 #include "base/strings/string_util.h" 30 #include "base/strings/string_util.h"
29 #include "base/strings/utf_string_conversions.h" 31 #include "base/strings/utf_string_conversions.h"
30 #include "base/time/time.h" 32 #include "base/time/time.h"
31 #include "base/version.h" 33 #include "base/version.h"
32 #include "base/win/registry.h" 34 #include "base/win/registry.h"
33 #include "base/win/windows_version.h" 35 #include "base/win/windows_version.h"
34 #include "chrome/installer/setup/installer_state.h" 36 #include "chrome/installer/setup/installer_state.h"
35 #include "chrome/installer/setup/setup_constants.h" 37 #include "chrome/installer/setup/setup_constants.h"
36 #include "chrome/installer/setup/user_hive_visitor.h" 38 #include "chrome/installer/setup/user_hive_visitor.h"
37 #include "chrome/installer/util/app_registration_data.h" 39 #include "chrome/installer/util/app_registration_data.h"
38 #include "chrome/installer/util/google_update_constants.h" 40 #include "chrome/installer/util/google_update_constants.h"
41 #include "chrome/installer/util/install_util.h"
39 #include "chrome/installer/util/installation_state.h" 42 #include "chrome/installer/util/installation_state.h"
40 #include "chrome/installer/util/master_preferences.h" 43 #include "chrome/installer/util/master_preferences.h"
41 #include "chrome/installer/util/master_preferences_constants.h" 44 #include "chrome/installer/util/master_preferences_constants.h"
42 #include "chrome/installer/util/util_constants.h" 45 #include "chrome/installer/util/util_constants.h"
43 #include "courgette/courgette.h" 46 #include "courgette/courgette.h"
44 #include "courgette/third_party/bsdiff/bsdiff.h" 47 #include "courgette/third_party/bsdiff/bsdiff.h"
45 48
46 namespace installer { 49 namespace installer {
47 50
48 namespace { 51 namespace {
49 52
53 // Event log provider registry location and value names.
54 // TODO(http://crbug.com/668397): Make this string depend on the branding then
55 // as well.
56 constexpr wchar_t kEventLogProviderRegPath[] =
57 L"SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\chrome";
58
50 // Returns true if product |type| cam be meaningfully installed without the 59 // Returns true if product |type| cam be meaningfully installed without the
51 // --multi-install flag. 60 // --multi-install flag.
52 bool SupportsSingleInstall(BrowserDistribution::Type type) { 61 bool SupportsSingleInstall(BrowserDistribution::Type type) {
53 return (type == BrowserDistribution::CHROME_BROWSER || 62 return (type == BrowserDistribution::CHROME_BROWSER ||
54 type == BrowserDistribution::CHROME_FRAME); 63 type == BrowserDistribution::CHROME_FRAME);
55 } 64 }
56 65
57 // Returns true if the "lastrun" value in |root|\|key_path| (a path to Chrome's 66 // Returns true if the "lastrun" value in |root|\|key_path| (a path to Chrome's
58 // ClientState key for a user) indicates that Chrome has been used within the 67 // ClientState key for a user) indicates that Chrome has been used within the
59 // last 28 days. 68 // last 28 days.
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 UNPACK_STATUS_COUNT, UNPACK_STATUS_COUNT + 1, 662 UNPACK_STATUS_COUNT, UNPACK_STATUS_COUNT + 1,
654 base::HistogramBase::kUmaTargetedHistogramFlag) 663 base::HistogramBase::kUmaTargetedHistogramFlag)
655 ->Add(unpack_status); 664 ->Add(unpack_status);
656 665
657 base::SparseHistogram::FactoryGet( 666 base::SparseHistogram::FactoryGet(
658 std::string(kUnPackNTSTATUSMetricsName) + "_" + consumer_name, 667 std::string(kUnPackNTSTATUSMetricsName) + "_" + consumer_name,
659 base::HistogramBase::kUmaTargetedHistogramFlag) 668 base::HistogramBase::kUmaTargetedHistogramFlag)
660 ->Add(status); 669 ->Add(status);
661 } 670 }
662 671
672 void RegisterEventLogProvider(const base::FilePath& install_directory,
673 const base::Version& version) {
674 VLOG(1) << "Registering Chrome's event log provider at "
675 << kEventLogProviderRegPath;
676
677 std::unique_ptr<WorkItemList> work_item_list(WorkItem::CreateWorkItemList());
678 work_item_list->set_log_message("Register event log provider");
679
680 work_item_list->AddCreateRegKeyWorkItem(
681 HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default);
682 // Speicifes the number of event categories defined in the dll.
683 work_item_list->AddSetRegValueWorkItem(
684 HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
685 L"CategoryCount", static_cast<DWORD>(1), true);
686 // Specifies the event type emitted by this event source.
687 work_item_list->AddSetRegValueWorkItem(
688 HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
689 L"TypesSupported",
690 static_cast<DWORD>(EVENTLOG_ERROR_TYPE | EVENTLOG_INFORMATION_TYPE |
691 EVENTLOG_WARNING_TYPE),
692 true);
693
694 const base::FilePath provider(
695 install_directory.AppendASCII(version.GetString())
696 .Append(FILE_PATH_LITERAL("eventlog_provider.dll")));
697
698 static constexpr const wchar_t* kFileKeys[] = {
699 L"CategoryMessageFile", L"EventMessageFile", L"ParameterMessageFile",
700 };
701 for (const wchar_t* file_key : kFileKeys) {
702 work_item_list->AddSetRegValueWorkItem(
703 HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
704 file_key, provider.value(), true);
705 }
706
707 // if the operation fails we log the error but still continue because none of
708 // these are critical for the proper operation of the browser.
709 if (!work_item_list->Do())
710 work_item_list->Rollback();
711 }
712
713 void DeRegisterEventLogProvider() {
714 // TODO(http://crbug.com/668120): If the Event Viewer is open the provider dll
715 // will fail to get deleted. This doesn't fail the uninstallation altogether
716 // but leaves files behind.
717 InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, kEventLogProviderRegPath,
718 WorkItem::kWow64Default);
719 }
720
663 ScopedTokenPrivilege::ScopedTokenPrivilege(const wchar_t* privilege_name) 721 ScopedTokenPrivilege::ScopedTokenPrivilege(const wchar_t* privilege_name)
664 : is_enabled_(false) { 722 : is_enabled_(false) {
665 HANDLE temp_handle; 723 HANDLE temp_handle;
666 if (!::OpenProcessToken(::GetCurrentProcess(), 724 if (!::OpenProcessToken(::GetCurrentProcess(),
667 TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY, 725 TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY,
668 &temp_handle)) { 726 &temp_handle)) {
669 return; 727 return;
670 } 728 }
671 token_.Set(temp_handle); 729 token_.Set(temp_handle);
672 730
(...skipping 22 matching lines...) Expand all
695 } 753 }
696 754
697 ScopedTokenPrivilege::~ScopedTokenPrivilege() { 755 ScopedTokenPrivilege::~ScopedTokenPrivilege() {
698 if (is_enabled_ && previous_privileges_.PrivilegeCount != 0) { 756 if (is_enabled_ && previous_privileges_.PrivilegeCount != 0) {
699 ::AdjustTokenPrivileges(token_.Get(), FALSE, &previous_privileges_, 757 ::AdjustTokenPrivileges(token_.Get(), FALSE, &previous_privileges_,
700 sizeof(TOKEN_PRIVILEGES), NULL, NULL); 758 sizeof(TOKEN_PRIVILEGES), NULL, NULL);
701 } 759 }
702 } 760 }
703 761
704 } // namespace installer 762 } // namespace installer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698