Install the chrome event log provider together with the browser.

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <windows.h>
 #include <shlobj.h>
 #include <time.h>
 
@@ skipping 124 matching lines @@
   reg_path.append(installer::kChromeExe);
   VLOG(1) << "Adding Chrome to Media player list at " << reg_path;
   std::unique_ptr<WorkItem> work_item(WorkItem::CreateCreateRegKeyWorkItem(
       HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default));
 
   // if the operation fails we log the error but still continue
   if (!work_item.get()->Do())
     LOG(ERROR) << "Could not add Chrome to media player inclusion list.";
 }
 
+void RegisterChromesEventlogProvider(const base::FilePath& chrome_exe) {

[grt (UTC plus 2), 2016/11/16 15:04:44]

nit: RegisterChromeEventLogProvider or maybe just RegisterEventLogProvider is
there is only Chrome these days. it's your call.

[grt (UTC plus 2), 2016/11/16 15:04:44]

i think it makes sense to move this into setup_util.{cc,h} along with a function
to unregister the provider (called by the code in uninstall.cc) so that the code
for these two operations can be physically close should any changes ever be
needed to both.

[pastarmovj, 2016/11/17 15:34:42]

Done.

[pastarmovj, 2016/11/17 15:34:43]

Done.

+  base::string16 reg_path(installer::kEventlogProvidersRegPath);
+  // registry paths can also be appended like file system path
+  reg_path.push_back(base::FilePath::kSeparators[0]);
+  reg_path.append(installer::kChromeEventLogProviderName);
+  VLOG(1) << "Registering  Chrome's event log provider at " << reg_path;

[grt (UTC plus 2), 2016/11/16 15:04:44]

nit: remove extra space in log message

[pastarmovj, 2016/11/17 15:34:42]

Done.

+  std::unique_ptr<WorkItem> work_item(WorkItem::CreateCreateRegKeyWorkItem(

[grt (UTC plus 2), 2016/11/16 15:04:44]

rather than creating and using individual items like this, create a
WorkItemList, add the items you care about to it, then:
  if (!work_item_list->Do())
    work_item_list->Rollback();
this will ensure that any failure will return the state of the machine to the
way it was before the first mutation.

if certain items should not result in failure of the whole operation, you can
call set_best_effort(true) on them. if some items shouldn't be rolled back even
in case of failure, you can call set_rollback_enabled(false) on them. my guess
is that the default behavior is probably okay for this

[pastarmovj, 2016/11/17 15:34:43]

Done. You are right that those make sense only as a whole so the default
transaction logic is just right.

+      HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default));
+
+  // if the operation fails we log the error but still continue because none of
+  // these are critical for the proper operation of the browser.
+  if (!work_item.get()->Do()) {
+    LOG(ERROR) << "Could not register Chrome's event log provider. "
+               << "Failed to create registry key: " << reg_path << ".";
+    return;
+  }
+
+  work_item.reset(WorkItem::CreateSetRegValueWorkItem(
+      HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default,
+      installer::kCategoryCount, static_cast<DWORD>(1), true));
+  if (!work_item.get()->Do()) {
+    LOG(ERROR) << "Could not register Chrome's event log provider. "
+               << "Failed to set registry value: " << installer::kCategoryCount
+               << ".";
+  }
+  work_item.reset(WorkItem::CreateSetRegValueWorkItem(
+      HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default,
+      installer::kTypesSupported, static_cast<DWORD>(7), true));
+  if (!work_item.get()->Do()) {
+    LOG(ERROR) << "Could not register Chrome's event log provider. "
+               << "Failed to set registry value: " << installer::kTypesSupported
+               << ".";
+  }
+
+  const wchar_t* const file_keys[] = {

[grt (UTC plus 2), 2016/11/16 15:04:44]

nit: static constexpr const wchar_t* kFileKeys[] = {...}

[pastarmovj, 2016/11/17 15:34:43]

Done.

+      installer::kCategoryMessageFile,
+      installer::kEventMessageFile,
+      installer::kParameterMessageFile,
+  };
+  for (int i = 0; i < arraysize(file_keys); ++i) {

[grt (UTC plus 2), 2016/11/16 15:04:44]

nit: for (const wchar_t* file_key : file_keys) {

[pastarmovj, 2016/11/17 15:34:43]

Done.

+    work_item.reset(WorkItem::CreateSetRegValueWorkItem(
+        HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default,
+        file_keys[i], chrome_exe.value(), true));
+    if (!work_item.get()->Do()) {
+      LOG(ERROR) << "Could not register Chrome's event log provider. "
+                 << "Failed to set registry value: " << file_keys[i] << ".";
+    }
+  }
+}
+
 // Copy master_preferences file provided to installer, in the same folder
 // as chrome.exe so Chrome first run can find it. This function will be called
 // only on the first install of Chrome.
 void CopyPreferenceFileForFirstRun(
     const installer::InstallerState& installer_state,
     const base::FilePath& prefs_source_path) {
   base::FilePath prefs_dest_path(installer_state.target_path().AppendASCII(
       installer::kDefaultMasterPrefs));
   if (!base::CopyFile(prefs_source_path, prefs_dest_path)) {
     VLOG(1) << "Failed to copy master preferences from:"
@@ skipping 281 matching lines @@
   ExecuteAndLogShortcutOperation(
       ShellUtil::SHORTCUT_LOCATION_START_MENU_ROOT, dist,
       start_menu_properties, shortcut_operation);
 }
 
 void RegisterChromeOnMachine(const installer::InstallerState& installer_state,
                              const installer::Product& product,
                              bool make_chrome_default) {
   DCHECK(product.is_chrome());
 
+  const base::FilePath chrome_exe(
+      installer_state.target_path().Append(installer::kChromeExe));
+
   // Try to add Chrome to Media Player shim inclusion list. We don't do any
   // error checking here because this operation will fail if user doesn't
   // have admin rights and we want to ignore the error.
   AddChromeToMediaPlayerList();
 
+  // Try to register the event log provider for Chrome, but only if it is a
+  // system profile because this step admin privileges.
+  if (installer_state.system_install())
+    RegisterChromesEventlogProvider(chrome_exe);
+
   // Make Chrome the default browser if desired when possible. Otherwise, only
   // register it with Windows.
   BrowserDistribution* dist = product.distribution();
-  const base::FilePath chrome_exe(
-      installer_state.target_path().Append(installer::kChromeExe));
   VLOG(1) << "Registering Chrome as browser: " << chrome_exe.value();
   if (make_chrome_default && ShellUtil::CanMakeChromeDefaultUnattended()) {
     int level = ShellUtil::CURRENT_USER;
     if (installer_state.system_install())
       level = level | ShellUtil::SYSTEM_LEVEL;
     ShellUtil::MakeChromeDefault(dist, level, chrome_exe, true);
   } else {
     ShellUtil::RegisterChromeBrowser(dist, chrome_exe, base::string16(), false);
   }
 }
@@ skipping 251 matching lines @@
   // Read master_preferences copied beside chrome.exe at install.
   MasterPreferences prefs(installation_root.AppendASCII(kDefaultMasterPrefs));
   base::FilePath chrome_exe(installation_root.Append(kChromeExe));
   CreateOrUpdateShortcuts(
       chrome_exe, chrome, prefs, CURRENT_USER, install_operation);
 
   UpdateDefaultBrowserBeaconForPath(chrome_exe);
 }
 
 }  // namespace installer