Install the chrome event log provider together with the browser.

chrome/installer/setup/setup_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares util functions for setup project.
 
 #include "chrome/installer/setup/setup_util.h"
 
 #include <windows.h>
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
+#include <limits>
+#include <memory>
 #include <set>
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/version.h"
 #include "base/win/registry.h"
 #include "base/win/windows_version.h"
 #include "chrome/installer/setup/installer_state.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/setup/user_hive_visitor.h"
 #include "chrome/installer/util/app_registration_data.h"
 #include "chrome/installer/util/google_update_constants.h"
+#include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/installation_state.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/master_preferences_constants.h"
 #include "chrome/installer/util/util_constants.h"
 #include "courgette/courgette.h"
 #include "courgette/third_party/bsdiff/bsdiff.h"
 
 namespace installer {
 
 namespace {
 
+// Event log provider registry location and value names.
+constexpr wchar_t kEventLogProviderRegPath[] =
+    L"SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\chrome";
+
 // Returns true if product |type| cam be meaningfully installed without the
 // --multi-install flag.
 bool SupportsSingleInstall(BrowserDistribution::Type type) {
   return (type == BrowserDistribution::CHROME_BROWSER ||
           type == BrowserDistribution::CHROME_FRAME);
 }
 
 // Returns true if the "lastrun" value in |root|\|key_path| (a path to Chrome's
 // ClientState key for a user) indicates that Chrome has been used within the
 // last 28 days.
@@ skipping 593 matching lines @@
       UNPACK_STATUS_COUNT, UNPACK_STATUS_COUNT + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->Add(unpack_status);
 
   base::SparseHistogram::FactoryGet(
       std::string(kUnPackNTSTATUSMetricsName) + "_" + consumer_name,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->Add(status);
 }
 
+void RegisterEventLogProvider(const base::FilePath& install_directory) {

[grt (UTC plus 2), 2016/11/22 10:41:25]

nit: either rename |install_directory| to |version_directory|, or have this take
|target_path| and |version| as two args and compose them here. i'm leaning
toward the latter since it hides an implementation detail from the caller.

[pastarmovj, 2016/11/23 14:27:26]

Done.

+  VLOG(1) << "Registering Chrome's event log provider at "
+          << kEventLogProviderRegPath;
+
+  std::unique_ptr<WorkItemList> work_item_list(WorkItem::CreateWorkItemList());
+
+  work_item_list->AddCreateRegKeyWorkItem(
+      HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default);
+  // Speicifes the number of event categories defined in the dll.
+  work_item_list->AddSetRegValueWorkItem(
+      HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
+      L"CategoryCount", static_cast<DWORD>(1), true);
+  // Specifies the event type emitted by this event source.
+  work_item_list->AddSetRegValueWorkItem(
+      HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
+      L"TypesSupported",
+      static_cast<DWORD>(EVENTLOG_ERROR_TYPE | EVENTLOG_INFORMATION_TYPE |
+                         EVENTLOG_WARNING_TYPE),
+      true);
+
+  base::FilePath provider(install_directory);

[grt (UTC plus 2), 2016/11/22 10:41:25]

nit: 
  base::FilePath provider(
      install_directory.Append(FILE_PATH_LITERAL("eventlog_provider.dll");
(or whatever git cl format says) and remove the next line

[pastarmovj, 2016/11/23 14:27:26]

Done.

+  provider = provider.Append(FILE_PATH_LITERAL("eventlog_provider.dll"));
+
+  static const wchar_t* file_keys[] = {

[grt (UTC plus 2), 2016/11/22 10:41:25]

nit: static constexpr const wchar_t* kFileKeys[] = {

[pastarmovj, 2016/11/23 14:27:26]

Done.

+      L"CategoryMessageFile", L"EventMessageFile", L"ParameterMessageFile",
+  };
+  for (const wchar_t* file_key : file_keys) {
+    work_item_list->AddSetRegValueWorkItem(
+        HKEY_LOCAL_MACHINE, kEventLogProviderRegPath, WorkItem::kWow64Default,
+        file_key, provider.value(), true);
+  }
+
+  // if the operation fails we log the error but still continue because none of
+  // these are critical for the proper operation of the browser.
+  if (!work_item_list->Do()) {
+    work_item_list->Rollback();
+    LOG(ERROR) << "Could not register Chrome's event log provider.";

[grt (UTC plus 2), 2016/11/22 10:41:25]

WorkitemList will emit a log message very similar to this. i propose you remove
this line (and the braces around the "if" body) and insert something like:
  work_item_list->set_log_message("Register event log provider");
up around line 675

[pastarmovj, 2016/11/23 14:27:25]

Done.

+  }
+}
+
+void DeRegisterEventLogProvider() {
+  InstallUtil::DeleteRegistryKey(HKEY_LOCAL_MACHINE, kEventLogProviderRegPath,
+                                 WorkItem::kWow64Default);
+}
+
 ScopedTokenPrivilege::ScopedTokenPrivilege(const wchar_t* privilege_name)
     : is_enabled_(false) {
   HANDLE temp_handle;
   if (!::OpenProcessToken(::GetCurrentProcess(),
                           TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY,
                           &temp_handle)) {
     return;
   }
   token_.Set(temp_handle);
 
@@ skipping 22 matching lines @@
 }
 
 ScopedTokenPrivilege::~ScopedTokenPrivilege() {
   if (is_enabled_ && previous_privileges_.PrivilegeCount != 0) {
     ::AdjustTokenPrivileges(token_.Get(), FALSE, &previous_privileges_,
                             sizeof(TOKEN_PRIVILEGES), NULL, NULL);
   }
 }
 
 }  // namespace installer