Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2507743002: Update the bookmark tooltip text only when necessary (Closed)

Created:
4 years, 1 month ago by oshima
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the bookmark tooltip text only when necessary BUG=612682 TEST=manual. see bug for repro step. Committed: https://crrev.com/e1b6ed732fb14986aa4d1db97de7208356b861f7 Cr-Commit-Position: refs/heads/master@{#432874}

Patch Set 1 #

Patch Set 2 : Update the bookmark tooltip text only when necessary #

Total comments: 8

Patch Set 3 : Update the bookmark tooltip text only when necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 2 chunks +25 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
oshima
4 years, 1 month ago (2016-11-17 00:12:21 UTC) #12
oshima
4 years, 1 month ago (2016-11-17 00:13:20 UTC) #13
sky
LGTM with the following. https://codereview.chromium.org/2507743002/diff/40001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right): https://codereview.chromium.org/2507743002/diff/40001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc#newcode270 chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:270: int max_width = tooltip_manager->GetMaxWidth(location); Please ...
4 years, 1 month ago (2016-11-17 01:08:28 UTC) #14
oshima
https://codereview.chromium.org/2507743002/diff/40001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right): https://codereview.chromium.org/2507743002/diff/40001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc#newcode270 chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:270: int max_width = tooltip_manager->GetMaxWidth(location); On 2016/11/17 01:08:28, sky wrote: ...
4 years, 1 month ago (2016-11-17 14:02:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507743002/80001
4 years, 1 month ago (2016-11-17 14:03:01 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 1 month ago (2016-11-17 14:53:48 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 14:55:58 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1b6ed732fb14986aa4d1db97de7208356b861f7
Cr-Commit-Position: refs/heads/master@{#432874}

Powered by Google App Engine
This is Rietveld 408576698