Issue 250773010: [NaCl SDK] easy_template: fix bug when using % in an expression template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250773010: [NaCl SDK] easy_template: fix bug when using % in an expression template. (Closed)

Created:
6 years, 8 months ago by binji

Modified:
6 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	native_client_sdk/src/build_tools/easy_template.py	View	1	1 chunk	+12 lines, -3 lines	0 comments	Download
	M	native_client_sdk/src/build_tools/tests/easy_template_test.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

binji

fixed bug. Forgot to replace % with %% after expression match {{}}

6 years, 7 months ago (2014-04-28 17:21:23 UTC) #3

binji

6 years, 7 months ago (2014-04-28 19:28:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r266627 (presubmit successful).