sandbox/linux/services/credentials.cc - Issue 250773003: NaCl Linux: create NaClSandbox class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/services/credentials.cc

Issue 250773003: NaCl Linux: create NaClSandbox class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address nits. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/services/credentials.cc

diff --git a/sandbox/linux/services/credentials.cc b/sandbox/linux/services/credentials.cc

index 8077c68d4d45c4801615f2ea025b256b32417425..51a535d47992d72fc110f1ab20569b4e893b51a4 100644

--- a/sandbox/linux/services/credentials.cc

+++ b/sandbox/linux/services/credentials.cc

@@ -192,7 +192,7 @@ bool Credentials::HasOpenDirectory(int proc_fd) {

return false;

}

- CHECK_GE(proc_self_fd, 0);

+ PCHECK(0 <= proc_self_fd);

// Ownership of proc_self_fd is transferred here, it must not be closed

// or modified afterwards except via dir.

« no previous file with comments | « components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc ('k') | no next file » | no next file with comments »