Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 250773002: Reland "Recompute overflow after transform changes" (Closed)

Created:
6 years, 8 months ago by trchen
Modified:
6 years, 7 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, rune+blink, chrishtr, zoltan1, dsinclair, sof, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, Inactive, bemjb+rendering_chromium.org, pdr., ojan, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@build_hack
Visibility:
Public.

Description

Reland "Recompute overflow after transform changes" This CL adds a special code path that is very similar to simplifiedLayout. When the only change on an element is the transform, we can do the minimal work to recompute the layout overflow without much overhead from layout. This is done by adding an overflow recalculation phase after style changes, if a RenderObject doesn't need layout and has moved transformed children, the special code path will kick in. BUG=352460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172833

Patch Set 1 #

Patch Set 2 : revise as ojan suggested #

Patch Set 3 : rebased #

Patch Set 4 : rebase again #

Patch Set 5 : again... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -58 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/compositing/overflow/transform-should-update-container-overflow.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/compositing/overflow/transform-should-update-container-overflow-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/compositing/repaint/should-not-repaint-composited-transform.html View 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/repaint/should-not-repaint-composited-transform-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 4 1 chunk +85 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 3 4 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 4 5 chunks +39 lines, -27 lines 0 comments Download
M Source/core/rendering/style/StyleDifference.h View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
trchen
This should be ready for trybots by the time https://codereview.chromium.org/255433003/ lands.
6 years, 8 months ago (2014-04-25 02:40:39 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-25 04:35:05 UTC) #2
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 7 months ago (2014-04-29 00:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/250773002/80001
6 years, 7 months ago (2014-04-29 00:34:45 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 03:43:50 UTC) #5
Message was sent while issue was closed.
Change committed as 172833

Powered by Google App Engine
This is Rietveld 408576698