Issue 2507723002: Remove unnecessary indexing passes from serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2507723002: Remove unnecessary indexing passes from serialization. (Closed)

Created:
4 years, 1 month ago by asgerf

Modified:
4 years, 1 month ago

Reviewers:
ahe, Kevin Millikin (Google)

CC:
dart-kernel+reviews_google.com

Target Ref:
refs/heads/master

Project:
Dart Kernel

Visibility:
Public.

Remove unnecessary indexing passes from serialization. Computing the index for variables, labels, and switch cases is now done on-the-fly instead of as separate passes. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/kernel/commit/118a4be934f3af4dcf4014dbbd7a1875c17ebb9f

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -96 lines)			Patch
	M	lib/binary/ast_to_binary.dart	View		16 chunks	+62 lines, -96 lines	0 comments	Download
	A	test/serialize_bench.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years, 1 month ago (2016-11-16 14:13:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
118a4be934f3af4dcf4014dbbd7a1875c17ebb9f (presubmit successful).