Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2507703002: Make offline directory name public. (Closed)

Created:
4 years, 1 month ago by Olivier
Modified:
4 years, 1 month ago
Reviewers:
gambard
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make offline directory name public. This is needed to allow the offline loader to find the pages inside this directory. BUG=664124 Committed: https://crrev.com/ade080aed5a40cf5a4af4385144899eb0deff351 Cr-Commit-Position: refs/heads/master@{#432434}

Patch Set 1 #

Patch Set 2 : add an S #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M ios/chrome/browser/reading_list/url_downloader.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Olivier
4 years, 1 month ago (2016-11-16 08:29:54 UTC) #2
gambard
lgtm
4 years, 1 month ago (2016-11-16 08:32:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507703002/20001
4 years, 1 month ago (2016-11-16 08:32:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 08:44:08 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 08:47:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ade080aed5a40cf5a4af4385144899eb0deff351
Cr-Commit-Position: refs/heads/master@{#432434}

Powered by Google App Engine
This is Rietveld 408576698