Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2507683003:
Port improvements of some builtins. (Closed)
|
Created:
4 years, 1 month ago by predrag.rudic Modified:
4 years, 1 month ago Reviewers:
ivica.bogosavljevic CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMIPS64: Port `Reland [arm64] Improve some new builtins.`
Port a1103a117c7fcd5484251336ac9f89ccafefa62f
Original commit message:
- Simplify the variable-length pop sequence on entry. (It now uses
smaller code with no branches.)
- Use conditional compare to merge branches where appropriate.
- Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more
efficiently.
- Only load 'undefined' and 'null' once per builtin.
- A few other small improvements.
Committed: https://crrev.com/7724a25515b5efca997ecbdd8ebbd89bac8a23e0
Cr-Commit-Position: refs/heads/master@{#41113}
Patch Set 1 #Patch Set 2 : Another optimisation #Messages
Total messages: 16 (10 generated)
Description was changed from ========== Port improvements of some builtins. Merge branch 'master' of https://chromium.googlesource.com/v8/v8 Merge branch 'master' of https://chromium.googlesource.com/v8/v8 Fix 'MIPS: Fix Utf16CharacterStream scanner crash due to missaligned access on MIPS' Changed test caused TwoByteExternalBufferedStream to fail so additional fixes were nedded. Test is now improved because chunks now begin on alternating even and odd addresses. Also TwoByteExternalBufferedStream is not necessary for ARM architecture. BUG= ========== to ========== Port improvements of some builtins. ==========
predrag.rudic@imgtec.com changed reviewers: + ivica.bogosavljevic@imgtec.com
PTAL
You will need to change the title and the decription when doing a porting: MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements.
On 2016/11/18 13:23:26, ivica.bogosavljevic wrote: > You will need to change the title and the decription when doing a porting: > > MIPS64: Port `Reland [arm64] Improve some new builtins.` > > Port a1103a117c7fcd5484251336ac9f89ccafefa62f > > Original commit message > - Simplify the variable-length pop sequence on entry. (It now uses > smaller code with no branches.) > - Use conditional compare to merge branches where appropriate. > - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more > efficiently. > - Only load 'undefined' and 'null' once per builtin. > - A few other small improvements. lgtm
Description was changed from ========== Port improvements of some builtins. ========== to ========== MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message: - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. ==========
The CQ bit was checked by predrag.rudic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by predrag.rudic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message: - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. ========== to ========== MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message: - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message: - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. ========== to ========== MIPS64: Port `Reland [arm64] Improve some new builtins.` Port a1103a117c7fcd5484251336ac9f89ccafefa62f Original commit message: - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. Committed: https://crrev.com/7724a25515b5efca997ecbdd8ebbd89bac8a23e0 Cr-Commit-Position: refs/heads/master@{#41113} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7724a25515b5efca997ecbdd8ebbd89bac8a23e0 Cr-Commit-Position: refs/heads/master@{#41113} |
