third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 2507673002: Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2507673002: Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (2) (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 0bd98bca6d30fa8ac49f065ddad4b715583cedbb..a4aae0c4f202d3135d9832a01dc30e160b345ac3 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -39,6 +39,7 @@

#include "core/html/track/TextTrack.h"

#include "platform/MIMETypeRegistry.h"

#include "platform/Supplementable.h"

+#include "platform/WebTaskRunner.h"

#include "platform/audio/AudioSourceProvider.h"

#include "public/platform/WebAudioSourceProviderClient.h"

#include "public/platform/WebMediaPlayerClient.h"

@@ -655,8 +656,8 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,

Member<CueTimeline> m_cueTimeline;

HeapVector<Member<ScriptPromiseResolver>> m_playPromiseResolvers;

- std::unique_ptr<CancellableTaskFactory> m_playPromiseResolveTask;

- std::unique_ptr<CancellableTaskFactory> m_playPromiseRejectTask;

+ TaskHandle m_playPromiseResolveTaskHandle;

+ TaskHandle m_playPromiseRejectTaskHandle;

HeapVector<Member<ScriptPromiseResolver>> m_playPromiseResolveList;

HeapVector<Member<ScriptPromiseResolver>> m_playPromiseRejectList;

ExceptionCode m_playPromiseErrorCode;