Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2507643002: Removes tracking for fake audio streams. (Closed)

Created:
4 years, 1 month ago by alokp
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes tracking for fake audio streams. Fake audio streams no longer hold raw pointer for AudioManager. So even if fake streams outlive AudioManager, there is no concern for use-after-free bugs. BUG=608049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -60 lines) Patch
M media/audio/audio_manager_base.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/audio/fake_audio_input_stream.h View 3 chunks +10 lines, -6 lines 0 comments Download
M media/audio/fake_audio_input_stream.cc View 4 chunks +27 lines, -22 lines 0 comments Download
M media/audio/fake_audio_manager.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/fake_audio_output_stream.h View 2 chunks +10 lines, -7 lines 0 comments Download
M media/audio/fake_audio_output_stream.cc View 2 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
DaleCurtis
4 years, 1 month ago (2016-11-16 21:57:29 UTC) #7
Don't want to take this approach because it special cases the fake stream away
from standard AudioOutputStream behavior.

Powered by Google App Engine
This is Rietveld 408576698