Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2507633002: Check for existence of logdog binary and logcat source before uploading. (Closed)

Created:
4 years, 1 month ago by bpastene
Modified:
4 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for existence of logdog binary and logcat source before uploading. BUG=654538 Committed: https://crrev.com/4fe1c4e43e30d69d933a5849cdb10df5dae4ce50 Cr-Commit-Position: refs/heads/master@{#432587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/android/test_wrapper/logdog_wrapper.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bpastene
4 years, 1 month ago (2016-11-16 02:15:00 UTC) #2
jbudorick
lgtm Looking at some of the logs in the duped bug, I'm wondering if there ...
4 years, 1 month ago (2016-11-16 02:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507633002/1
4 years, 1 month ago (2016-11-16 17:40:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 19:23:02 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe1c4e43e30d69d933a5849cdb10df5dae4ce50
Cr-Commit-Position: refs/heads/master@{#432587}

Powered by Google App Engine
This is Rietveld 408576698