Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2507543004: Revert of Reland: Show the tutorial during OOBE (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Show the tutorial during OOBE (patchset #1 id:1 of https://codereview.chromium.org/2498153003/ ) Reason for revert: failed again. https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19922 BUG=664881 Original issue's description: > Reland: Show the tutorial during OOBE > > Original issue > https://codereview.chromium.org/2497723002/ > > Revert was speculative; reland is speculative > > TBR=dtseng@chromium.org > > Committed: https://crrev.com/8292e619f94f0fa361a17b40e450556a0bcf6f9c > Cr-Commit-Position: refs/heads/master@{#432260} TBR=dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a3be0a9f456261db33481b0621714dea8cd563ac Cr-Commit-Position: refs/heads/master@{#432354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
horo
Created Revert of Reland: Show the tutorial during OOBE
4 years, 1 month ago (2016-11-16 02:11:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507543004/1
4 years, 1 month ago (2016-11-16 02:12:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 02:13:14 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 02:17:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3be0a9f456261db33481b0621714dea8cd563ac
Cr-Commit-Position: refs/heads/master@{#432354}

Powered by Google App Engine
This is Rietveld 408576698