Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2507543003: arc: enable use_new_wrapper_types for {scale_factor,screen_rect}.mojom (Closed)

Created:
4 years, 1 month ago by Yusuke Sato
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: enable use_new_wrapper_types for {scale_factor,screen_rect}.mojom BUG=662510 BUG=624136 TEST=try Committed: https://crrev.com/035067294b27c4fc3ef2e10db62037c8f3f50359 Cr-Commit-Position: refs/heads/master@{#432391}

Patch Set 1 #

Patch Set 2 : move screen_rect too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/arc/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Yusuke Sato
PTAL too. Looks like we can do this for free.
4 years, 1 month ago (2016-11-16 00:23:28 UTC) #3
Luis Héctor Chávez
lgtm ha! should have tried to do that from the beginning :P
4 years, 1 month ago (2016-11-16 03:05:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507543003/20001
4 years, 1 month ago (2016-11-16 03:06:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 06:28:18 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:33:28 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/035067294b27c4fc3ef2e10db62037c8f3f50359
Cr-Commit-Position: refs/heads/master@{#432391}

Powered by Google App Engine
This is Rietveld 408576698