Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2507543002: Revert of [Sync] Put session tracker in charge of maintaining local state. (Closed)

Created:
4 years, 1 month ago by Nicolas Zea
Modified:
4 years, 1 month ago
Reviewers:
maxbogue, skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Put session tracker in charge of maintaining local state. (patchset #5 id:120001 of https://codereview.chromium.org/2494533002/ ) Reason for revert: crbug.com/665314 crbug.com/665524 Original issue's description: > [Sync] Put session tracker in charge of maintaining local state. > > Previously, the session tracker was only updated when local tabs were > available in the TabModel. It was not updated with sync data from a previous > session (and as a result, we had to pass around the restored_data list > at association time in order to handle restoring placeholder tabs). > > The session tracker now gets updated at startup of previous local state, > which is then used when reassociating restored tabs. This is a purely > refactoring change that should not introduce external behavioral changes > (although internally the data is managed in a different way). > > To make this happen, InitFromSyncModel now treats local tabs and remote > tabs the same. In addition, the SyncedSessionTracker now has a > ReassociateTab method that can be called to update the tab id of a > SessionTab. > > This is all necessary in order to enable preserving tabs from a previous > session when they're not present in the TabModel (which can happen on > Android when a custom tab is opened, but the main tabbed activity is not > loaded). > > BUG=639009 > > Committed: https://crrev.com/7453d79b8ab314577881145ed341e8603bfdbe4f > Cr-Commit-Position: refs/heads/master@{#432006} TBR=maxbogue@chromium.org,skym@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639009 Committed: https://crrev.com/1cd87c1fd8b685edcd9b053def59a5d3f7b26056 Cr-Commit-Position: refs/heads/master@{#432229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -362 lines) Patch
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 8 chunks +16 lines, -22 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 5 chunks +34 lines, -11 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 15 chunks +85 lines, -86 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.h View 2 chunks +2 lines, -11 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M components/sync_sessions/synced_session_tracker_unittest.cc View 10 chunks +143 lines, -190 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nicolas Zea
Created Revert of [Sync] Put session tracker in charge of maintaining local state.
4 years, 1 month ago (2016-11-15 19:05:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507543002/1
4 years, 1 month ago (2016-11-15 19:06:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 19:07:34 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 19:34:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cd87c1fd8b685edcd9b053def59a5d3f7b26056
Cr-Commit-Position: refs/heads/master@{#432229}

Powered by Google App Engine
This is Rietveld 408576698