DescriptionRevert of [Sync] Put session tracker in charge of maintaining local state. (patchset #5 id:120001 of https://codereview.chromium.org/2494533002/ )
Reason for revert:
crbug.com/665314
crbug.com/665524
Original issue's description:
> [Sync] Put session tracker in charge of maintaining local state.
>
> Previously, the session tracker was only updated when local tabs were
> available in the TabModel. It was not updated with sync data from a previous
> session (and as a result, we had to pass around the restored_data list
> at association time in order to handle restoring placeholder tabs).
>
> The session tracker now gets updated at startup of previous local state,
> which is then used when reassociating restored tabs. This is a purely
> refactoring change that should not introduce external behavioral changes
> (although internally the data is managed in a different way).
>
> To make this happen, InitFromSyncModel now treats local tabs and remote
> tabs the same. In addition, the SyncedSessionTracker now has a
> ReassociateTab method that can be called to update the tab id of a
> SessionTab.
>
> This is all necessary in order to enable preserving tabs from a previous
> session when they're not present in the TabModel (which can happen on
> Android when a custom tab is opened, but the main tabbed activity is not
> loaded).
>
> BUG=639009
>
> Committed: https://crrev.com/7453d79b8ab314577881145ed341e8603bfdbe4f
> Cr-Commit-Position: refs/heads/master@{#432006}
TBR=maxbogue@chromium.org,skym@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639009
Committed: https://crrev.com/1cd87c1fd8b685edcd9b053def59a5d3f7b26056
Cr-Commit-Position: refs/heads/master@{#432229}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|