Chromium Code Reviews
DescriptionRevert of android: Don't keep GSA alive if it supports account change broadcasts. (patchset #1 id:1 of https://codereview.chromium.org/2497313002/ )
Reason for revert:
Causing crashes, see crbug/665396
Original issue's description:
> android: Don't keep GSA alive if it supports account change broadcasts.
>
> Chrome currently connects to a bound service exposed by GSA to get
> account change notifications. This elevates GSA's priority for the
> system to the foreground level when Chrome is in the foreground,
> artificially increasing Chrome's memory footprint. On some phones, the
> memory consumption of the GSA process can be above 100MB (PSS), even
> though only the account change notifications are required.
>
> Newer versions of GSA send a broadcast intent when the account
> changes. This CL listens to the broadcasts, and disonnects from the GSA
> service when GSA support the account change broadcast mechanism, freing
> the memory for Chrome or other apps on the system.
>
> Note that Chrome still briefly connects to GSA on startup to confirm
> that it supports the broadcast. A forthcoming will remove this.
>
> BUG=614388
>
> Review-Url: https://codereview.chromium.org/2431223004
> Cr-Commit-Position: refs/heads/master@{#427840}
> (cherry picked from commit e1d19b388fc67f31372a4c2df33e20c0c18dfd97)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0d49cd8de23891fc2d4d4260271795c4c294bcd4
TBR=lizeb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=614388
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||