Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2507523003: Revert of android: Don't keep GSA alive if it supports account change broadcasts. (Closed)

Created:
4 years, 1 month ago by amineer
Modified:
4 years, 1 month ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of android: Don't keep GSA alive if it supports account change broadcasts. (patchset #1 id:1 of https://codereview.chromium.org/2497313002/ ) Reason for revert: Causing crashes, see crbug/665396 Original issue's description: > android: Don't keep GSA alive if it supports account change broadcasts. > > Chrome currently connects to a bound service exposed by GSA to get > account change notifications. This elevates GSA's priority for the > system to the foreground level when Chrome is in the foreground, > artificially increasing Chrome's memory footprint. On some phones, the > memory consumption of the GSA process can be above 100MB (PSS), even > though only the account change notifications are required. > > Newer versions of GSA send a broadcast intent when the account > changes. This CL listens to the broadcasts, and disonnects from the GSA > service when GSA support the account change broadcast mechanism, freing > the memory for Chrome or other apps on the system. > > Note that Chrome still briefly connects to GSA on startup to confirm > that it supports the broadcast. A forthcoming will remove this. > > BUG=614388 > > Review-Url: https://codereview.chromium.org/2431223004 > Cr-Commit-Position: refs/heads/master@{#427840} > (cherry picked from commit e1d19b388fc67f31372a4c2df33e20c0c18dfd97) > > Committed: https://chromium.googlesource.com/chromium/src/+/0d49cd8de23891fc2d4d4260271795c4c294bcd4 TBR=lizeb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=614388 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -158 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 4 chunks +7 lines, -5 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java View 1 chunk +0 lines, -138 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 7 chunks +5 lines, -12 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
amineer
Created Revert of android: Don't keep GSA alive if it supports account change broadcasts.
4 years, 1 month ago (2016-11-15 20:11:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507523003/1
4 years, 1 month ago (2016-11-15 20:12:35 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 1 month ago (2016-11-15 20:12:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507523003/1
4 years, 1 month ago (2016-11-15 20:13:43 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:38:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698