[Payments] Order billing addresses by frecency.

[Payments] Order billing addresses by frecency.

BUG=665525
Committed: https://crrev.com/92a47788c5b2ef36661a356e661b2db39a5776ec
Cr-Commit-Position: refs/heads/master@{#432896}

[sebsg, 2016-11-16 21:07:39]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-11-16 21:11:45]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-11-16 21:16:27]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2016-11-16 21:16:27]

Hi Rouslan, could you please take a look? Thanks!

[please use gerrit instead, 2016-11-16 21:19:00]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 21:19:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-16 21:26:02]

lgtm after the comments are addressed

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:80:
* The map from GUIDs to profiles that can be used for billing address. This
cache avoids
Remove references to "map" in the comment.

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:310:
card.getBillingAddressId())) {
Put this commonly used loop into a helper method, like
"getBillingAddress(String)", instead of repeating it several times in code.

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:558:
0, new DropdownKeyValue(billingAddress.getIdentifier(),
Good to see this fixed :-)

[commit-bot: I haz the power, 2016-11-16 23:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:36:30]

Dry run: This issue passed the CQ dry run.

[sebsg, 2016-11-17 16:19:19]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-11-17 16:19:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2507523002/#ps60001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-11-17 16:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:55:36]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-17 16:59:49]

Description was changed from

==========
[Payments] Order billing addresses by frecency.

BUG=665525
==========

to

==========
[Payments] Order billing addresses by frecency.

BUG=665525

Committed: https://crrev.com/92a47788c5b2ef36661a356e661b2db39a5776ec
Cr-Commit-Position: refs/heads/master@{#432896}
==========

[commit-bot: I haz the power, 2016-11-17 16:59:50]

Patchset 2 (id:??) landed as
https://crrev.com/92a47788c5b2ef36661a356e661b2db39a5776ec
Cr-Commit-Position: refs/heads/master@{#432896}

[sebsg, 2016-11-17 19:39:56]

Thanks

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:80:
* The map from GUIDs to profiles that can be used for billing address. This
cache avoids
On 2016/11/16 21:26:01, rouslan wrote:
> Remove references to "map" in the comment.

Done.

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:310:
card.getBillingAddressId())) {
On 2016/11/16 21:26:01, rouslan wrote:
> Put this commonly used loop into a helper method, like
> "getBillingAddress(String)", instead of repeating it several times in code.

As discussed offline, will leave as is.

https://codereview.chromium.org/2507523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:558:
0, new DropdownKeyValue(billingAddress.getIdentifier(),
On 2016/11/16 21:26:01, rouslan wrote:
> Good to see this fixed :-)

Acknowledged.