Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 2507503002: Use touch events to report stylus events (Closed)
Patch Set: fixed nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 document, p1.id, p1.screenPosition, p1.position, 142 document, p1.id, p1.screenPosition, p1.position,
143 FloatSize(p1.radiusX, p1.radiusY), 143 FloatSize(p1.radiusX, p1.radiusY),
144 p1.rotationAngle, p1.force, String()); 144 p1.rotationAngle, p1.force, String());
145 145
146 // Test touchstart. 146 // Test touchstart.
147 { 147 {
148 TouchList* touchList = TouchList::create(); 148 TouchList* touchList = TouchList::create();
149 touchList->append(touch0); 149 touchList->append(touch0);
150 TouchEvent* touchEvent = TouchEvent::create( 150 TouchEvent* touchEvent = TouchEvent::create(
151 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow, 151 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow,
152 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto); 152 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto,
153 WebPointerProperties::PointerType::Touch);
Navid Zolghadr 2016/11/30 16:37:03 nit: I know it is just a simple getter/setter. But
153 154
154 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 155 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
155 ASSERT_EQ(1u, webTouchBuilder.touchesLength); 156 ASSERT_EQ(1u, webTouchBuilder.touchesLength);
156 EXPECT_EQ(WebInputEvent::TouchStart, webTouchBuilder.type); 157 EXPECT_EQ(WebInputEvent::TouchStart, webTouchBuilder.type);
157 EXPECT_EQ(WebTouchPoint::StatePressed, webTouchBuilder.touches[0].state); 158 EXPECT_EQ(WebTouchPoint::StatePressed, webTouchBuilder.touches[0].state);
158 EXPECT_FLOAT_EQ(p0.screenPosition.x, 159 EXPECT_FLOAT_EQ(p0.screenPosition.x,
159 webTouchBuilder.touches[0].screenPosition.x); 160 webTouchBuilder.touches[0].screenPosition.x);
160 EXPECT_FLOAT_EQ(p0.screenPosition.y, 161 EXPECT_FLOAT_EQ(p0.screenPosition.y,
161 webTouchBuilder.touches[0].screenPosition.y); 162 webTouchBuilder.touches[0].screenPosition.y);
162 EXPECT_FLOAT_EQ(p0.position.x, webTouchBuilder.touches[0].position.x); 163 EXPECT_FLOAT_EQ(p0.position.x, webTouchBuilder.touches[0].position.x);
163 EXPECT_FLOAT_EQ(p0.position.y, webTouchBuilder.touches[0].position.y); 164 EXPECT_FLOAT_EQ(p0.position.y, webTouchBuilder.touches[0].position.y);
164 EXPECT_FLOAT_EQ(p0.radiusX, webTouchBuilder.touches[0].radiusX); 165 EXPECT_FLOAT_EQ(p0.radiusX, webTouchBuilder.touches[0].radiusX);
165 EXPECT_FLOAT_EQ(p0.radiusY, webTouchBuilder.touches[0].radiusY); 166 EXPECT_FLOAT_EQ(p0.radiusY, webTouchBuilder.touches[0].radiusY);
166 EXPECT_FLOAT_EQ(p0.rotationAngle, webTouchBuilder.touches[0].rotationAngle); 167 EXPECT_FLOAT_EQ(p0.rotationAngle, webTouchBuilder.touches[0].rotationAngle);
167 EXPECT_FLOAT_EQ(p0.force, webTouchBuilder.touches[0].force); 168 EXPECT_FLOAT_EQ(p0.force, webTouchBuilder.touches[0].force);
168 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 169 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
169 } 170 }
170 171
171 // Test cancelable touchstart. 172 // Test cancelable touchstart.
172 { 173 {
173 TouchList* touchList = TouchList::create(); 174 TouchList* touchList = TouchList::create();
174 touchList->append(touch0); 175 touchList->append(touch0);
175 TouchEvent* touchEvent = TouchEvent::create( 176 TouchEvent* touchEvent = TouchEvent::create(
176 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow, 177 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow,
177 PlatformEvent::NoModifiers, true, false, true, 0, TouchActionAuto); 178 PlatformEvent::NoModifiers, true, false, true, 0, TouchActionAuto,
179 WebPointerProperties::PointerType::Touch);
178 180
179 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 181 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
180 EXPECT_EQ(WebInputEvent::Blocking, webTouchBuilder.dispatchType); 182 EXPECT_EQ(WebInputEvent::Blocking, webTouchBuilder.dispatchType);
181 } 183 }
182 184
183 // Test touchmove. 185 // Test touchmove.
184 { 186 {
185 TouchList* activeTouchList = TouchList::create(); 187 TouchList* activeTouchList = TouchList::create();
186 TouchList* movedTouchList = TouchList::create(); 188 TouchList* movedTouchList = TouchList::create();
187 activeTouchList->append(touch0); 189 activeTouchList->append(touch0);
188 activeTouchList->append(touch1); 190 activeTouchList->append(touch1);
189 movedTouchList->append(touch0); 191 movedTouchList->append(touch0);
190 TouchEvent* touchEvent = TouchEvent::create( 192 TouchEvent* touchEvent = TouchEvent::create(
191 activeTouchList, activeTouchList, movedTouchList, 193 activeTouchList, activeTouchList, movedTouchList,
192 EventTypeNames::touchmove, domWindow, PlatformEvent::NoModifiers, false, 194 EventTypeNames::touchmove, domWindow, PlatformEvent::NoModifiers, false,
193 false, true, 0, TouchActionAuto); 195 false, true, 0, TouchActionAuto,
196 WebPointerProperties::PointerType::Touch);
194 197
195 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 198 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
196 ASSERT_EQ(2u, webTouchBuilder.touchesLength); 199 ASSERT_EQ(2u, webTouchBuilder.touchesLength);
197 EXPECT_EQ(WebInputEvent::TouchMove, webTouchBuilder.type); 200 EXPECT_EQ(WebInputEvent::TouchMove, webTouchBuilder.type);
198 EXPECT_EQ(WebTouchPoint::StateMoved, webTouchBuilder.touches[0].state); 201 EXPECT_EQ(WebTouchPoint::StateMoved, webTouchBuilder.touches[0].state);
199 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[1].state); 202 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[1].state);
200 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id); 203 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id);
201 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id); 204 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id);
202 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 205 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
203 } 206 }
204 207
205 // Test touchmove, different point yields same ordering. 208 // Test touchmove, different point yields same ordering.
206 { 209 {
207 TouchList* activeTouchList = TouchList::create(); 210 TouchList* activeTouchList = TouchList::create();
208 TouchList* movedTouchList = TouchList::create(); 211 TouchList* movedTouchList = TouchList::create();
209 activeTouchList->append(touch0); 212 activeTouchList->append(touch0);
210 activeTouchList->append(touch1); 213 activeTouchList->append(touch1);
211 movedTouchList->append(touch1); 214 movedTouchList->append(touch1);
212 TouchEvent* touchEvent = TouchEvent::create( 215 TouchEvent* touchEvent = TouchEvent::create(
213 activeTouchList, activeTouchList, movedTouchList, 216 activeTouchList, activeTouchList, movedTouchList,
214 EventTypeNames::touchmove, domWindow, PlatformEvent::NoModifiers, false, 217 EventTypeNames::touchmove, domWindow, PlatformEvent::NoModifiers, false,
215 false, true, 0, TouchActionAuto); 218 false, true, 0, TouchActionAuto,
219 WebPointerProperties::PointerType::Touch);
216 220
217 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 221 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
218 ASSERT_EQ(2u, webTouchBuilder.touchesLength); 222 ASSERT_EQ(2u, webTouchBuilder.touchesLength);
219 EXPECT_EQ(WebInputEvent::TouchMove, webTouchBuilder.type); 223 EXPECT_EQ(WebInputEvent::TouchMove, webTouchBuilder.type);
220 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[0].state); 224 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[0].state);
221 EXPECT_EQ(WebTouchPoint::StateMoved, webTouchBuilder.touches[1].state); 225 EXPECT_EQ(WebTouchPoint::StateMoved, webTouchBuilder.touches[1].state);
222 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id); 226 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id);
223 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id); 227 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id);
224 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 228 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
225 } 229 }
226 230
227 // Test touchend. 231 // Test touchend.
228 { 232 {
229 TouchList* activeTouchList = TouchList::create(); 233 TouchList* activeTouchList = TouchList::create();
230 TouchList* releasedTouchList = TouchList::create(); 234 TouchList* releasedTouchList = TouchList::create();
231 activeTouchList->append(touch0); 235 activeTouchList->append(touch0);
232 releasedTouchList->append(touch1); 236 releasedTouchList->append(touch1);
233 TouchEvent* touchEvent = TouchEvent::create( 237 TouchEvent* touchEvent = TouchEvent::create(
234 activeTouchList, activeTouchList, releasedTouchList, 238 activeTouchList, activeTouchList, releasedTouchList,
235 EventTypeNames::touchend, domWindow, PlatformEvent::NoModifiers, false, 239 EventTypeNames::touchend, domWindow, PlatformEvent::NoModifiers, false,
236 false, false, 0, TouchActionAuto); 240 false, false, 0, TouchActionAuto,
241 WebPointerProperties::PointerType::Touch);
237 242
238 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 243 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
239 ASSERT_EQ(2u, webTouchBuilder.touchesLength); 244 ASSERT_EQ(2u, webTouchBuilder.touchesLength);
240 EXPECT_EQ(WebInputEvent::TouchEnd, webTouchBuilder.type); 245 EXPECT_EQ(WebInputEvent::TouchEnd, webTouchBuilder.type);
241 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[0].state); 246 EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[0].state);
242 EXPECT_EQ(WebTouchPoint::StateReleased, webTouchBuilder.touches[1].state); 247 EXPECT_EQ(WebTouchPoint::StateReleased, webTouchBuilder.touches[1].state);
243 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id); 248 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id);
244 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id); 249 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id);
245 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 250 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
246 } 251 }
247 252
248 // Test touchcancel. 253 // Test touchcancel.
249 { 254 {
250 TouchList* activeTouchList = TouchList::create(); 255 TouchList* activeTouchList = TouchList::create();
251 TouchList* cancelledTouchList = TouchList::create(); 256 TouchList* cancelledTouchList = TouchList::create();
252 cancelledTouchList->append(touch0); 257 cancelledTouchList->append(touch0);
253 cancelledTouchList->append(touch1); 258 cancelledTouchList->append(touch1);
254 TouchEvent* touchEvent = TouchEvent::create( 259 TouchEvent* touchEvent = TouchEvent::create(
255 activeTouchList, activeTouchList, cancelledTouchList, 260 activeTouchList, activeTouchList, cancelledTouchList,
256 EventTypeNames::touchcancel, domWindow, PlatformEvent::NoModifiers, 261 EventTypeNames::touchcancel, domWindow, PlatformEvent::NoModifiers,
257 false, false, false, 0, TouchActionAuto); 262 false, false, false, 0, TouchActionAuto,
263 WebPointerProperties::PointerType::Touch);
258 264
259 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 265 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
260 ASSERT_EQ(2u, webTouchBuilder.touchesLength); 266 ASSERT_EQ(2u, webTouchBuilder.touchesLength);
261 EXPECT_EQ(WebInputEvent::TouchCancel, webTouchBuilder.type); 267 EXPECT_EQ(WebInputEvent::TouchCancel, webTouchBuilder.type);
262 EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[0].state); 268 EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[0].state);
263 EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[1].state); 269 EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[1].state);
264 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id); 270 EXPECT_EQ(p0.id, webTouchBuilder.touches[0].id);
265 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id); 271 EXPECT_EQ(p1.id, webTouchBuilder.touches[1].id);
266 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 272 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
267 } 273 }
268 274
269 // Test max point limit. 275 // Test max point limit.
270 { 276 {
271 TouchList* touchList = TouchList::create(); 277 TouchList* touchList = TouchList::create();
272 TouchList* changedTouchList = TouchList::create(); 278 TouchList* changedTouchList = TouchList::create();
273 for (int i = 0; i <= static_cast<int>(WebTouchEvent::kTouchesLengthCap) * 2; 279 for (int i = 0; i <= static_cast<int>(WebTouchEvent::kTouchesLengthCap) * 2;
274 ++i) { 280 ++i) {
275 Touch* touch = Touch::create( 281 Touch* touch = Touch::create(
276 toLocalFrame(webViewImpl->page()->mainFrame()), document, i, 282 toLocalFrame(webViewImpl->page()->mainFrame()), document, i,
277 p0.screenPosition, p0.position, FloatSize(p0.radiusX, p0.radiusY), 283 p0.screenPosition, p0.position, FloatSize(p0.radiusX, p0.radiusY),
278 p0.rotationAngle, p0.force, String()); 284 p0.rotationAngle, p0.force, String());
279 touchList->append(touch); 285 touchList->append(touch);
280 changedTouchList->append(touch); 286 changedTouchList->append(touch);
281 } 287 }
282 TouchEvent* touchEvent = TouchEvent::create( 288 TouchEvent* touchEvent = TouchEvent::create(
283 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow, 289 touchList, touchList, touchList, EventTypeNames::touchstart, domWindow,
284 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto); 290 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto,
291 WebPointerProperties::PointerType::Touch);
285 292
286 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 293 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
287 ASSERT_EQ(static_cast<unsigned>(WebTouchEvent::kTouchesLengthCap), 294 ASSERT_EQ(static_cast<unsigned>(WebTouchEvent::kTouchesLengthCap),
288 webTouchBuilder.touchesLength); 295 webTouchBuilder.touchesLength);
289 } 296 }
290 } 297 }
291 298
292 TEST(WebInputEventConversionTest, InputEventsScaling) { 299 TEST(WebInputEventConversionTest, InputEventsScaling) {
293 const std::string baseURL("http://www.test1.com/"); 300 const std::string baseURL("http://www.test1.com/");
294 const std::string fileName("fixed_layout.html"); 301 const std::string fileName("fixed_layout.html");
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 559
553 { 560 {
554 Touch* touch = 561 Touch* touch =
555 Touch::create(toLocalFrame(webViewImpl->page()->mainFrame()), document, 562 Touch::create(toLocalFrame(webViewImpl->page()->mainFrame()), document,
556 0, FloatPoint(10, 9.5), FloatPoint(3.5, 2), 563 0, FloatPoint(10, 9.5), FloatPoint(3.5, 2),
557 FloatSize(4, 4.5), 0, 0, String()); 564 FloatSize(4, 4.5), 0, 0, String());
558 TouchList* touchList = TouchList::create(); 565 TouchList* touchList = TouchList::create();
559 touchList->append(touch); 566 touchList->append(touch);
560 TouchEvent* touchEvent = TouchEvent::create( 567 TouchEvent* touchEvent = TouchEvent::create(
561 touchList, touchList, touchList, EventTypeNames::touchmove, domWindow, 568 touchList, touchList, touchList, EventTypeNames::touchmove, domWindow,
562 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto); 569 PlatformEvent::NoModifiers, false, false, true, 0, TouchActionAuto,
570 WebPointerProperties::PointerType::Touch);
563 571
564 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent); 572 WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
565 ASSERT_EQ(1u, webTouchBuilder.touchesLength); 573 ASSERT_EQ(1u, webTouchBuilder.touchesLength);
566 EXPECT_EQ(10, webTouchBuilder.touches[0].screenPosition.x); 574 EXPECT_EQ(10, webTouchBuilder.touches[0].screenPosition.x);
567 EXPECT_FLOAT_EQ(9.5, webTouchBuilder.touches[0].screenPosition.y); 575 EXPECT_FLOAT_EQ(9.5, webTouchBuilder.touches[0].screenPosition.y);
568 EXPECT_FLOAT_EQ(3.5, webTouchBuilder.touches[0].position.x); 576 EXPECT_FLOAT_EQ(3.5, webTouchBuilder.touches[0].position.x);
569 EXPECT_FLOAT_EQ(2, webTouchBuilder.touches[0].position.y); 577 EXPECT_FLOAT_EQ(2, webTouchBuilder.touches[0].position.y);
570 EXPECT_FLOAT_EQ(4, webTouchBuilder.touches[0].radiusX); 578 EXPECT_FLOAT_EQ(4, webTouchBuilder.touches[0].radiusX);
571 EXPECT_FLOAT_EQ(4.5, webTouchBuilder.touches[0].radiusY); 579 EXPECT_FLOAT_EQ(4.5, webTouchBuilder.touches[0].radiusY);
572 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType); 580 EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
1328 EXPECT_EQ(ScrollInertialPhaseNonMomentum, 1336 EXPECT_EQ(ScrollInertialPhaseNonMomentum,
1329 platformGestureBuilder.inertialPhase()); 1337 platformGestureBuilder.inertialPhase());
1330 EXPECT_TRUE(platformGestureBuilder.synthetic()); 1338 EXPECT_TRUE(platformGestureBuilder.synthetic());
1331 EXPECT_EQ(ScrollGranularity::ScrollByPage, 1339 EXPECT_EQ(ScrollGranularity::ScrollByPage,
1332 platformGestureBuilder.deltaUnits()); 1340 platformGestureBuilder.deltaUnits());
1333 EXPECT_EQ(12345U, platformGestureBuilder.uniqueTouchEventId()); 1341 EXPECT_EQ(12345U, platformGestureBuilder.uniqueTouchEventId());
1334 } 1342 }
1335 } 1343 }
1336 1344
1337 } // namespace blink 1345 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebInputEventConversion.cpp ('k') | ui/events/ozone/evdev/touch_evdev_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698