Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2507493002: Remove LOG spam from password_manager_presenter_unittest.cc (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
Reviewers:
vasilii, kolos1
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LOG spam from password_manager_presenter_unittest.cc There are forgotten LOG statement in password_manager_presenter_unittest.cc, which should have been deleted before https://codereview.chromium.org/2439953004/ landed. This CL removes them. R=kolos@chromium.org BUG=655949 Committed: https://crrev.com/c93ba9194684d6a4ac93e3588f006af252b2f58c Cr-Commit-Position: refs/heads/master@{#433175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/ui/passwords/password_manager_presenter_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
vabr (Chromium)
Hi Maxim, Please review this change. If it looks good, please feel free to send ...
4 years, 1 month ago (2016-11-15 17:56:00 UTC) #3
vabr (Chromium)
Hi Vasilii, While Maxim is traveling, could you please review this change instead of him? ...
4 years, 1 month ago (2016-11-18 10:35:45 UTC) #7
vasilii
lgtm
4 years, 1 month ago (2016-11-18 10:44:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507493002/1
4 years, 1 month ago (2016-11-18 10:44:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 11:16:21 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 11:18:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c93ba9194684d6a4ac93e3588f006af252b2f58c
Cr-Commit-Position: refs/heads/master@{#433175}

Powered by Google App Engine
This is Rietveld 408576698