Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: media/filters/gpu_video_decoder.h

Issue 2507463004: Fix broken SurfaceView usage on < M devices. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_GPU_VIDEO_DECODER_H_ 5 #ifndef MEDIA_FILTERS_GPU_VIDEO_DECODER_H_
6 #define MEDIA_FILTERS_GPU_VIDEO_DECODER_H_ 6 #define MEDIA_FILTERS_GPU_VIDEO_DECODER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const; 156 void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const;
157 157
158 // Provided to the |request_surface_cb_| callback given during construction; 158 // Provided to the |request_surface_cb_| callback given during construction;
159 // sets or changes the output surface. 159 // sets or changes the output surface.
160 void OnSurfaceAvailable(int surface_id); 160 void OnSurfaceAvailable(int surface_id);
161 161
162 // If the VDA supports external surfaces, we must wait for the surface before 162 // If the VDA supports external surfaces, we must wait for the surface before
163 // completing initialization. This will be called by OnSurfaceAvailable() once 163 // completing initialization. This will be called by OnSurfaceAvailable() once
164 // the surface is known or immediately by Initialize() if external surfaces 164 // the surface is known or immediately by Initialize() if external surfaces
165 // are unsupported. 165 // are unsupported.
166 void CompleteInitialization(); 166 void CompleteInitialization(int surface_id);
167 167
168 bool needs_bitstream_conversion_; 168 bool needs_bitstream_conversion_;
169 169
170 GpuVideoAcceleratorFactories* factories_; 170 GpuVideoAcceleratorFactories* factories_;
171 171
172 // For requesting a suface to render to. If this is null the VDA will return 172 // For requesting a suface to render to. If this is null the VDA will return
173 // normal video frames and not render them to a surface. 173 // normal video frames and not render them to a surface.
174 RequestSurfaceCB request_surface_cb_; 174 RequestSurfaceCB request_surface_cb_;
175 175
176 scoped_refptr<MediaLog> media_log_; 176 scoped_refptr<MediaLog> media_log_;
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 // Bound to factories_->GetMessageLoop(). 259 // Bound to factories_->GetMessageLoop().
260 // NOTE: Weak pointers must be invalidated before all other member variables. 260 // NOTE: Weak pointers must be invalidated before all other member variables.
261 base::WeakPtrFactory<GpuVideoDecoder> weak_factory_; 261 base::WeakPtrFactory<GpuVideoDecoder> weak_factory_;
262 262
263 DISALLOW_COPY_AND_ASSIGN(GpuVideoDecoder); 263 DISALLOW_COPY_AND_ASSIGN(GpuVideoDecoder);
264 }; 264 };
265 265
266 } // namespace media 266 } // namespace media
267 267
268 #endif // MEDIA_FILTERS_GPU_VIDEO_DECODER_H_ 268 #endif // MEDIA_FILTERS_GPU_VIDEO_DECODER_H_
OLDNEW
« no previous file with comments | « no previous file | media/filters/gpu_video_decoder.cc » ('j') | media/gpu/android_video_decode_accelerator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698