Add kill switch for Notification images

Add kill switch for Notification images

The NotificationImage Blink feature is currently experimental, but will
later be shipped by default. This patch adds a Finch kill switch so that
the feature can be rolled back if necessary.

BUG=614456
Committed: https://crrev.com/b0c683c3f0ca7bbefada86313f6d7c691467eba6
Cr-Commit-Position: refs/heads/master@{#432471}

[johnme, 2016-11-15 18:17:56]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 18:18:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[johnme, 2016-11-15 18:34:35]

johnme@chromium.org changed reviewers:
+ aelias@chromium.org, creis@chromium.org, peter@chromium.org

[johnme, 2016-11-15 18:34:36]

peter@chromium.org: Please review changes in c*/browser/notifications/

aelias@chromium.org: Please review changes in third_party/WebKit/

creis@chromium.org: Please review changes in content/child/ & content/public/

Thanks all!

[Peter Beverloo, 2016-11-15 19:39:20]

lgtm % unambiguous naming. thanks John!

https://codereview.chromium.org/2507463003/diff/1/chrome/browser/notification...
File
chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
(right):

https://codereview.chromium.org/2507463003/diff/1/chrome/browser/notification...
chrome/browser/notifications/platform_notification_service_interactive_uitest.cc:707:
class PlatformNotificationServiceBrowserTestWithoutImages
"WithoutImages" implies a much broader scope than just the `image` property, can
we s/Images/BigImage/?

https://codereview.chromium.org/2507463003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2507463003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:115: const base::Feature
kNotificationImage{"NotificationImage",
Again: "Image" will be very ambiguous for readers outside of our team. Please
consider consistently using "BigImage", "ContentImage" or something like.

[commit-bot: I haz the power, 2016-11-15 20:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:06:57]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-11-15 20:30:23]

lgtm

[johnme, 2016-11-16 00:33:12]

Addressed review comments - thanks :)

https://codereview.chromium.org/2507463003/diff/1/chrome/browser/notification...
File
chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
(right):

https://codereview.chromium.org/2507463003/diff/1/chrome/browser/notification...
chrome/browser/notifications/platform_notification_service_interactive_uitest.cc:707:
class PlatformNotificationServiceBrowserTestWithoutImages
On 2016/11/15 19:39:20, Peter Beverloo wrote:
> "WithoutImages" implies a much broader scope than just the `image` property,
can
> we s/Images/BigImage/?

Done (ContentImage).

https://codereview.chromium.org/2507463003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2507463003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:115: const base::Feature
kNotificationImage{"NotificationImage",
On 2016/11/15 19:39:20, Peter Beverloo wrote:
> Again: "Image" will be very ambiguous for readers outside of our team. Please
> consider consistently using "BigImage", "ContentImage" or something like.

Done (ContentImage).

[johnme, 2016-11-16 00:33:27]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:34:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-11-16 01:01:54]

content/ LGTM.

[Peter Beverloo, 2016-11-16 01:15:22]

The CQ bit was unchecked by peter@chromium.org

[Peter Beverloo, 2016-11-16 01:15:28]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-11-16 01:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2507463003/#ps40001
(title: "Rename test subclass")

[commit-bot: I haz the power, 2016-11-16 01:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2016-11-16 01:16:03]

The CQ bit was unchecked by peter@chromium.org

[johnme, 2016-11-16 10:56:15]

johnme@chromium.org changed reviewers:
+ foolip@chromium.org

[johnme, 2016-11-16 10:56:16]

foolip: please approve Source/platform/RuntimeEnabledFeatures.in - thanks :)

[foolip, 2016-11-16 11:09:21]

On 2016/11/16 10:56:16, johnme wrote:
> foolip: please approve Source/platform/RuntimeEnabledFeatures.in - thanks :)

lgtm

[johnme, 2016-11-16 11:40:14]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2016-11-16 11:40:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 13:04:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 13:09:52]

Description was changed from

==========
Add kill switch for Notification images

The NotificationImage Blink feature is currently experimental, but will
later be shipped by default. This patch adds a Finch kill switch so that
the feature can be rolled back if necessary.

BUG=614456
==========

to

==========
Add kill switch for Notification images

The NotificationImage Blink feature is currently experimental, but will
later be shipped by default. This patch adds a Finch kill switch so that
the feature can be rolled back if necessary.

BUG=614456

Committed: https://crrev.com/b0c683c3f0ca7bbefada86313f6d7c691467eba6
Cr-Commit-Position: refs/heads/master@{#432471}
==========

[commit-bot: I haz the power, 2016-11-16 13:09:53]

Patchset 3 (id:??) landed as
https://crrev.com/b0c683c3f0ca7bbefada86313f6d7c691467eba6
Cr-Commit-Position: refs/heads/master@{#432471}