Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2507453002: [sensors] Magnetometer sensor bindings implementation (Closed)

Created:
4 years, 1 month ago by shalamov
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Magnetometer sensor bindings implementation This CL implements blink bindings for Magnetometer sensor [1]. Following layout tests added to test new functionality: IDL tests. - third_party/WebKit/LayoutTests/sensor/idl-Magnetometer.html Magnetometer tests. - third_party/WebKit/LayoutTests/sensor/magnetometer.html Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o [1] ED specification for Magnetometer https://w3c.github.io/magnetometer/ BUG=661478 Committed: https://crrev.com/d310abe41b192142f4cb31eb1854d2c51eff25db Cr-Commit-Position: refs/heads/master@{#432840}

Patch Set 1 #

Patch Set 2 : Update expected results for global interface listing #

Patch Set 3 : Remove unused includes #

Total comments: 1

Patch Set 4 : Use makeUnique #

Patch Set 5 : Rebased to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/sensor/idl-Magnetometer.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/sensor/magnetometer.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/Magnetometer.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/Magnetometer.cpp View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/Magnetometer.idl View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/MagnetometerReading.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/MagnetometerReading.cpp View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/MagnetometerReading.idl View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/MagnetometerReadingInit.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
shalamov
Please take a look.
4 years, 1 month ago (2016-11-16 14:43:01 UTC) #4
Mikhail
lgtm
4 years, 1 month ago (2016-11-16 14:47:14 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-16 16:53:42 UTC) #6
haraken
LGTM https://codereview.chromium.org/2507453002/diff/40001/third_party/WebKit/Source/modules/sensor/Magnetometer.cpp File third_party/WebKit/Source/modules/sensor/Magnetometer.cpp (right): https://codereview.chromium.org/2507453002/diff/40001/third_party/WebKit/Source/modules/sensor/Magnetometer.cpp#newcode38 third_party/WebKit/Source/modules/sensor/Magnetometer.cpp:38: new SensorReadingFactoryImpl<MagnetometerReading>()); Use makeUnique.
4 years, 1 month ago (2016-11-16 17:33:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507453002/80001
4 years, 1 month ago (2016-11-17 11:05:26 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-17 11:10:47 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 11:12:59 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d310abe41b192142f4cb31eb1854d2c51eff25db
Cr-Commit-Position: refs/heads/master@{#432840}

Powered by Google App Engine
This is Rietveld 408576698