Remove Widget::OnRootViewLayout().

Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538

Committed: https://crrev.com/37ff93058a11ab26e575152d207b849c009a4a00
Cr-Commit-Position: refs/heads/master@{#433462}

[tapted, 2016-11-17 06:24:40]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 06:24:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:15:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:15:32]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-11-17 07:50:33]

Description was changed from

==========
Remove OnRootViewLayout

BUG=
==========

to

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac will
stop using OnRootViewLayout() in crrev.com/2502813003.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

[tapted, 2016-11-17 07:50:33]

tapted@chromium.org changed reviewers:
+ erg@chromium.org

[tapted, 2016-11-17 07:59:03]

Hi Elliot, WDYT? This needs crrev/2502813003 to land first (where Mac stops
relying on OnRootViewLayout()), but I think it's safe to do after that.

[Elliot Glaysher, 2016-11-17 21:52:28]

lgtm

Given the changes in how we deal with async x11 mapping over the last year or
so, this is probably safe.

[tapted, 2016-11-17 22:16:21]

tapted@chromium.org changed reviewers:
+ sadrul@chromium.org

[tapted, 2016-11-17 22:16:22]

+sadrul for OWNERS - thanks!

[sadrul, 2016-11-18 19:04:50]

lgtm

[tapted, 2016-11-20 22:50:44]

Description was changed from

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac will
stop using OnRootViewLayout() in crrev.com/2502813003.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

to

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

[tapted, 2016-11-20 22:50:57]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-11-20 22:51:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 23:47:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479682257555370, "parent_rev":
["625fb94759f647a0fdb8e1daf75af2771c45130d", null], "commit_rev":
["e5f9d7fd216ee3affff4d4991900af96f35d8322", null]}

[commit-bot: I haz the power, 2016-11-20 23:47:30]

Description was changed from

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

to

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

[commit-bot: I haz the power, 2016-11-20 23:47:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-20 23:49:06]

Description was changed from

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538
==========

to

==========
Remove Widget::OnRootViewLayout().

It was added early on in the development for Linux Aura (r222386) to
propagate min/max window size properties to the window server. However,
it never really worked right because mapping the x11 window is
asynchronous: there's no guarantee a layout would occur after the window
was mapped. This was fixed in r325538 (and moved around in r388040 and
r389572).

Furthermore, calls to SetBounds() will also update the min and max size
properties. This is since r283945 (and a fix for that in r350338), so
the associated OnRootViewLayout() call is redundant.

Mac was also using OnRootViewLayout() but r368141 added
OnWidgetInitDone() which is a better place to trigger this. Mac
stopped using OnRootViewLayout() in r432821.

BUG=665280
TEST=Should be covered by WidgetTest.MinimumSizeConstraints added in
r325538

Committed: https://crrev.com/37ff93058a11ab26e575152d207b849c009a4a00
Cr-Commit-Position: refs/heads/master@{#433462}
==========

[commit-bot: I haz the power, 2016-11-20 23:49:07]

Patchset 1 (id:??) landed as
https://crrev.com/37ff93058a11ab26e575152d207b849c009a4a00
Cr-Commit-Position: refs/heads/master@{#433462}