MacViews: Fix flaky label selection tests.

MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches.

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162
Committed: https://crrev.com/50221c896a243c90466c5bed3ad83008198ea2b5
Cr-Commit-Position: refs/heads/master@{#433123}

[karandeepb, 2016-11-17 02:32:08]

Description was changed from

==========
MacViews: Fix flaky label selection tests.
==========

to

==========
MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches. 

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162
==========

[karandeepb, 2016-11-17 02:33:03]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-11-17 02:34:30]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 02:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-11-17 02:36:33]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2016-11-17 02:36:34]

PTAL msw@. From what I can see, we don't generally assign the result of
evaluating a command line switch to a static variable, which also helps in
injecting custom behavior in tests.

[commit-bot: I haz the power, 2016-11-17 04:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:37:37]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[msw, 2016-11-17 18:33:27]

hmmm, lgtm i guess, but this will slow down RenderText creation in production...

[karandeepb, 2016-11-17 23:43:33]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:45:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:41:41]

Description was changed from

==========
MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches. 

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162
==========

to

==========
MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches. 

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162
==========

[commit-bot: I haz the power, 2016-11-18 05:41:43]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-11-18 05:45:30]

Description was changed from

==========
MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches. 

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162
==========

to

==========
MacViews: Fix flaky label selection tests.

r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz
for these tests. It did this by appending the kEnableHarfBuzzRenderText switch
to the list of command line switches.

However RenderText::CreateInstance() assigns the result of evaluating the
presence of this switch to the static variable |use_native|. As a result, if
another test has already initialized the variable |use_native| to true,
appending the kEnableHarfBuzzRenderText switch has no effect. This causes the
Label selection tests to fail on Mac. To fix, make the |use_native| variable
non-static.

BUG=666162

Committed: https://crrev.com/50221c896a243c90466c5bed3ad83008198ea2b5
Cr-Commit-Position: refs/heads/master@{#433123}
==========

[commit-bot: I haz the power, 2016-11-18 05:45:31]

Patchset 1 (id:??) landed as
https://crrev.com/50221c896a243c90466c5bed3ad83008198ea2b5
Cr-Commit-Position: refs/heads/master@{#433123}