chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2507363002: MD Settings: Add Hotword (OK Google) section to search_page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2507363002: MD Settings: Add Hotword (OK Google) section to search_page (Closed)

Patch Set: Nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.js ('k') | chrome/browser/ui/webui/settings/search_engines_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index e51110a711d016d2690bd522b177b563e444e4cd..7067ecb661c6b532a7ec473fd7eaa0d35d6f12e7 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -1350,13 +1350,23 @@ void AddSearchStrings(content::WebUIDataSource* html_source) {

{"searchEnginesManageDescription",

IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES_DESCRIPTION},

{"searchOkGoogleLabel", IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL},

- {"searchOkGoogleLearnMoreLink",

- IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK},

- {"searchOkGoogleDescriptionLabel",

- IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL},

+ {"searchOkGoogleSubtextAlwaysOn",

+ IDS_SETTINGS_SEARCH_OK_GOOGLE_SUBTEXT_ALWAYS_ON},

+ {"searchOkGoogleSubtextNoHardware",

+ IDS_SETTINGS_SEARCH_OK_GOOGLE_SUBTEXT_NO_HARDWARE},

+ {"searchOkGoogleLearnMore", IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE},

+ {"searchOkGoogleAudioHistoryLabel",

+ IDS_SETTINGS_SEARCH_OK_GOOGLE_AUDIO_HISTORY_LABEL},

+ {"searchOkGoogleAudioHistorySubtext",

+ IDS_SETTINGS_SEARCH_OK_GOOGLE_AUDIO_HISTORY_SUBTEXT},

+ {"searchOkGoogleRetrain", IDS_SETTINGS_SEARCH_OK_GOOGLE_RETRAIN},

};

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

+ html_source->AddString("hotwordLearnMoreUrl",

+ chrome::kHotwordLearnMoreURL);

+ html_source->AddString("manageAudioHistoryUrl",

+ chrome::kManageAudioHistoryURL);

}

void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {