chrome/app/settings_strings.grdp - Issue 2507363002: MD Settings: Add Hotword (OK Google) section to search_page

Unified Diff: chrome/app/settings_strings.grdp

Issue 2507363002: MD Settings: Add Hotword (OK Google) section to search_page (Closed)

Patch Set: Self Review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | chrome/browser/extensions/api/settings_private/prefs_util.cc » ('j') | chrome/browser/resources/settings/controls/settings_checkbox.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/settings_strings.grdp

diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp

index 8fc66d4635c9448849fa33ad7fe3aca6922066df..b54d188bdf140892454051da15d2b6e64455bb2e 100644

--- a/chrome/app/settings_strings.grdp

+++ b/chrome/app/settings_strings.grdp

@@ -1577,11 +1577,27 @@

Enable "Ok Google" to start a voice search.

</message>

- <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK" desc="Link which opens page to learn more about the OK Google hotword.">

- Learn more

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_SUBTEXT_ALWAYS_ON" desc="Subtext describing when the OK Google hotword may be used.">

+ Say "Ok Google" when the screen is on and unlocked.

+ </message>

+ <if expr="chromeos">

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_SUBTEXT_NO_DSP" desc="Subtext describing when the OK Google hotword may be used for devices with no DSP.">

michaelpg 2016/11/27 22:25:31 nit: explain what DSP is or leave it out if it isn

stevenjb 2016/11/28 20:53:36 Done.

+ Say "Ok Google" in a new tab, google.com, and the App Launcher

+ </message>

+ </if>

+ <if expr="not chromeos">

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_SUBTEXT_NO_DSP" desc="Subtext describing when the OK Google hotword may be used for devices with no DSP.">

+ Say "Ok Google" in a new tab and google.com

+ </message>

+ </if>

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_AUDIO_HISTORY_LABEL" desc="Text to display when the user has audio history enabled.">

+ Voice and Audio Activity for <ph name="USER_EMAIL">$1<ex>joe@gmail.com</ex></ph>.

+ </message>

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_AUDIO_HISTORY_SUBTEXT" desc="Subtext describing why audio history is enabled.">

+ Enabled (required to use "Ok Google")

</message>

- <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL" desc="Label describing when the OK Google hotword may be used.">

- Say "Ok Google" in a new tab and google.com

+ <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_RETRAIN" desc="Text for button to retrain the OG Google hotword voice model.">

michaelpg 2016/11/27 22:25:32 OG => Ok

stevenjb 2016/11/28 20:53:36 Done.

+ Retrain

</message>