Remove NOTIFICATION_EXTENSION_UNLOADED from system_indicator API.

remove NOTIFICATION_EXTENSION_UNLOADED from system_indicator API

R=dewittj@chromium.org
BUG=354046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266820

[limasdf, 2014-04-25 16:08:34]

PTAL

[dewittj, 2014-04-28 21:25:49]

lgtm, one nit

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
(right):

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc:93:
->DispatchEventToExtension(extension_->id(), event.Pass());
Don't really need to change this eh?

[limasdf, 2014-04-28 22:51:16]

On 2014/04/28 21:25:49, dewittj wrote:
> lgtm, one nit
> 
>
https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
> File
chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
> (right):
> 
>
https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc:93:
> ->DispatchEventToExtension(extension_->id(), event.Pass());
> Don't really need to change this eh?

Thanks for the review!

[limasdf, 2014-04-28 22:51:40]

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
(right):

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc:93:
->DispatchEventToExtension(extension_->id(), event.Pass());
On 2014/04/28 21:25:49, dewittj wrote:
> Don't really need to change this eh?

Yes it doesnt really need to be change. But |event_router| is used exactly only
once. And we can reduce 1 code line here.
Sounds good?

[dewittj, 2014-04-28 23:34:51]

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
(right):

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc:93:
->DispatchEventToExtension(extension_->id(), event.Pass());
On 2014/04/28 22:51:40, sunglim wrote:
> On 2014/04/28 21:25:49, dewittj wrote:
> > Don't really need to change this eh?
> 
> Yes it doesnt really need to be change. But |event_router| is used exactly
only
> once. And we can reduce 1 code line here.
> Sounds good?

I know it sounds pedantic, but I'd rather the patch be focused and include only
formatting updates that are relevant to the actual lines changed.

[limasdf, 2014-04-29 00:09:29]

address review.

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
(right):

https://codereview.chromium.org/250733008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc:93:
->DispatchEventToExtension(extension_->id(), event.Pass());
On 2014/04/28 23:34:52, dewittj wrote:
> On 2014/04/28 22:51:40, sunglim wrote:
> > On 2014/04/28 21:25:49, dewittj wrote:
> > > Don't really need to change this eh?
> > 
> > Yes it doesnt really need to be change. But |event_router| is used exactly
> only
> > once. And we can reduce 1 code line here.
> > Sounds good?
> 
> I know it sounds pedantic, but I'd rather the patch be focused and include
only
> formatting updates that are relevant to the actual lines changed.

Yeah. Exactly. Thanks you for letting me know good habit!
Done.

[limasdf, 2014-04-29 00:17:22]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-29 00:18:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/250733008/40001

[commit-bot: I haz the power, 2014-04-29 01:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:07:28]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[limasdf, 2014-04-29 01:29:58]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-29 01:30:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/250733008/40001

[commit-bot: I haz the power, 2014-04-29 10:05:07]

Change committed as 266820