Report redirect UMA in offline interceptor

chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Index: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
index cb6322b837c265d36297139c6243278e33b70c16..0f57caee14e5fce43e88786887629c624c9b4034 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
@@ -249,10 +249,16 @@ class OfflinePageRequestJobTest : public testing::Test {
                         const std::string& extra_header_value,
                         content::ResourceType resource_type);
 
+  // Expect one count of|result| UMA reported and no more.

[fgorski, 2016/11/18 23:52:22]

nit: space before |

Expect exactly one...  drop " and no more."

First explain what "and no more" means. I s it opposite of explanation in 258?
In that case capture it more explicitly. 

[jianli, 2016/11/19 00:54:05]

Done.
Yes.

   void ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult result);
+  // Expect multiple |count| of |result| UMA reported and no more.

[fgorski, 2016/11/18 23:52:22]

Expect exactly |count|... and drop "and no more"

[jianli, 2016/11/19 00:54:05]

Done.

   void ExpectAggregatedRequestResultHistogramWithCount(
       OfflinePageRequestJob::AggregatedRequestResult result, int count);
+  // Expect one count of |result| UMA reported. Some other UMAs might also be
+  // reported.
+  void ExpectAggregatedRequestResultHistogramOnMultiBuckets(

[fgorski, 2016/11/18 23:52:22]

This is meant to be exactly one in specific bucket, and ignore other buckets?
Probably we could rename that to.

[jianli, 2016/11/19 00:54:05]

Eexactly one in specific bucket and other buckets could also have data.

+      OfflinePageRequestJob::AggregatedRequestResult result);
 
   net::TestURLRequestContext* url_request_context() {
     return test_url_request_context_.get();
@@ -459,6 +465,13 @@ void OfflinePageRequestJobTest::ExpectAggregatedRequestResultHistogramWithCount(
       kAggregatedRequestResultHistogram, static_cast<int>(result), count);
 }
 
+void
+OfflinePageRequestJobTest::ExpectAggregatedRequestResultHistogramOnMultiBuckets(
+    OfflinePageRequestJob::AggregatedRequestResult result) {
+  histogram_tester_.ExpectBucketCount(
+      kAggregatedRequestResultHistogram, static_cast<int>(result), 1);
+}
+
 void OfflinePageRequestJobTest::SavePage(
     const GURL& url,
     const ClientId& client_id,
@@ -840,7 +853,10 @@ TEST_F(OfflinePageRequestJobTest, LoadOfflinePageAfterRedirect) {
   ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id3(),
             offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
-  ExpectAggregatedRequestResultHistogram(
+  ExpectAggregatedRequestResultHistogramOnMultiBuckets(
+      OfflinePageRequestJob::AggregatedRequestResult::
+          REDIRECTED_ON_DISCONNECTED_NETWORK);
+  ExpectAggregatedRequestResultHistogramOnMultiBuckets(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_DISCONNECTED_NETWORK);
 }