Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_request_job.h

Issue 2507293006: Report redirect UMA in offline interceptor (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_request_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 SHOW_OFFLINE_ON_FLAKY_NETWORK, 43 SHOW_OFFLINE_ON_FLAKY_NETWORK,
44 PAGE_NOT_FOUND_ON_FLAKY_NETWORK, 44 PAGE_NOT_FOUND_ON_FLAKY_NETWORK,
45 SHOW_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK, 45 SHOW_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK,
46 PAGE_NOT_FOUND_ON_PROHIBITIVELY_SLOW_NETWORK, 46 PAGE_NOT_FOUND_ON_PROHIBITIVELY_SLOW_NETWORK,
47 PAGE_NOT_FRESH_ON_PROHIBITIVELY_SLOW_NETWORK, 47 PAGE_NOT_FRESH_ON_PROHIBITIVELY_SLOW_NETWORK,
48 SHOW_OFFLINE_ON_CONNECTED_NETWORK, 48 SHOW_OFFLINE_ON_CONNECTED_NETWORK,
49 PAGE_NOT_FOUND_ON_CONNECTED_NETWORK, 49 PAGE_NOT_FOUND_ON_CONNECTED_NETWORK,
50 NO_TAB_ID, 50 NO_TAB_ID,
51 NO_WEB_CONTENTS, 51 NO_WEB_CONTENTS,
52 SHOW_NET_ERROR_PAGE, 52 SHOW_NET_ERROR_PAGE,
53 REDIRECTED_ON_DISCONNECTED_NETWORK,
54 REDIRECTED_ON_FLAKY_NETWORK,
55 REDIRECTED_ON_PROHIBITIVELY_SLOW_NETWORK,
56 REDIRECTED_ON_CONNECTED_NETWORK,
53 AGGREGATED_REQUEST_RESULT_MAX 57 AGGREGATED_REQUEST_RESULT_MAX
54 }; 58 };
55 59
56 // Delegate that allows tests to overwrite certain behaviors. 60 // Delegate that allows tests to overwrite certain behaviors.
57 class Delegate { 61 class Delegate {
58 public: 62 public:
59 using TabIdGetter = base::Callback<bool(content::WebContents*, int*)>; 63 using TabIdGetter = base::Callback<bool(content::WebContents*, int*)>;
60 64
61 virtual ~Delegate() {} 65 virtual ~Delegate() {}
62 66
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 previews::PreviewsDecider* previews_decider_; 119 previews::PreviewsDecider* previews_decider_;
116 120
117 base::WeakPtrFactory<OfflinePageRequestJob> weak_ptr_factory_; 121 base::WeakPtrFactory<OfflinePageRequestJob> weak_ptr_factory_;
118 122
119 DISALLOW_COPY_AND_ASSIGN(OfflinePageRequestJob); 123 DISALLOW_COPY_AND_ASSIGN(OfflinePageRequestJob);
120 }; 124 };
121 125
122 } // namespace offline_pages 126 } // namespace offline_pages
123 127
124 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_ 128 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698