Report redirect UMA in offline interceptor

chrome/browser/android/offline_pages/offline_page_request_job.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 41 matching lines @@
   CONNECTED_NETWORK,
   // Force to load the offline page if it is available, though network is in
   // working condition.
   FORCE_OFFLINE_ON_CONNECTED_NETWORK
 };
 
 // This enum is used to tell all possible outcomes of handling network requests
 // that might serve offline contents.
 enum class RequestResult {
   OFFLINE_PAGE_SERVED,
+  REDIRECTED,

[fgorski, 2016/11/18 23:52:22]

add a comment someplace whether this indicates successful showing of an offline
page, please.

[jianli, 2016/11/19 00:54:05]

Done.

   NO_TAB_ID,
   NO_WEB_CONTENTS,
   PAGE_NOT_FRESH,
   OFFLINE_PAGE_NOT_FOUND
 };
 
 const char kUserDataKey[] = "offline_page_key";
 
 // Contains the info to handle offline page request.
 class OfflinePageRequestInfo : public base::SupportsUserData::Data {
@@ skipping 94 matching lines @@
         return OfflinePageRequestJob::AggregatedRequestResult::
             PAGE_NOT_FOUND_ON_FLAKY_NETWORK;
       case NetworkState::FORCE_OFFLINE_ON_CONNECTED_NETWORK:
         return OfflinePageRequestJob::AggregatedRequestResult::
             PAGE_NOT_FOUND_ON_CONNECTED_NETWORK;
       default:
         NOTREACHED();
     }
   }
 
+  if (request_result == RequestResult::REDIRECTED) {
+    switch (network_state) {
+      case NetworkState::DISCONNECTED_NETWORK:
+        return OfflinePageRequestJob::AggregatedRequestResult::
+            REDIRECTED_ON_DISCONNECTED_NETWORK;
+      case NetworkState::PROHIBITIVELY_SLOW_NETWORK:
+        return OfflinePageRequestJob::AggregatedRequestResult::
+            REDIRECTED_ON_PROHIBITIVELY_SLOW_NETWORK;
+      case NetworkState::FLAKY_NETWORK:
+        return OfflinePageRequestJob::AggregatedRequestResult::
+            REDIRECTED_ON_FLAKY_NETWORK;
+      case NetworkState::FORCE_OFFLINE_ON_CONNECTED_NETWORK:
+        return OfflinePageRequestJob::AggregatedRequestResult::
+            REDIRECTED_ON_CONNECTED_NETWORK;
+      default:
+        NOTREACHED();
+    }
+  }
+
   DCHECK_EQ(RequestResult::OFFLINE_PAGE_SERVED, request_result);
   DCHECK_NE(NetworkState::CONNECTED_NETWORK, network_state);
   switch (network_state) {
     case NetworkState::DISCONNECTED_NETWORK:
       return OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_DISCONNECTED_NETWORK;
     case NetworkState::PROHIBITIVELY_SLOW_NETWORK:
       return OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK;
     case NetworkState::FLAKY_NETWORK:
@@ skipping 131 matching lines @@
     const GURL& url,
     const OfflinePageHeader& offline_header,
     NetworkState network_state,
     base::WeakPtr<OfflinePageRequestJob> job,
     content::ResourceRequestInfo::WebContentsGetter web_contents_getter,
     const OfflinePageItem* offline_page) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   // If the match is for original URL, trigger the redirect.
   if (offline_page && url == offline_page->original_url) {
+    ReportRequestResult(RequestResult::REDIRECTED, network_state);
     NotifyOfflineRedirectOnUI(job, offline_page->url);
     return;
   }
 
   base::FilePath offline_file_path;
   RequestResult request_result = AccessOfflineFile(
       offline_header, network_state, job, web_contents_getter, offline_page,
       &offline_file_path);
 
   ReportRequestResult(request_result, network_state);
@@ skipping 320 matching lines @@
 
   URLRequestJob::NotifyHeadersComplete();
 }
 
 void OfflinePageRequestJob::SetDelegateForTesting(
     std::unique_ptr<Delegate> delegate) {
   delegate_ = std::move(delegate);
 }
 
 }  // namespace offline_pages