Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2507293004: [heap] Reland "Add a guard for restarting the memory reducer after mark-compact." (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Add a guard for restarting the memory reducer after mark-compact." This reverts commit 3c96c5e2325461c8d77e3843f9a637cf702563c4. The CL was reverted to see its impact on UMA memory counters. There was no impact, so we can safely reland the CL. BUG= Committed: https://crrev.com/b9f8ad002e06e0211ec02e9a206443bd8fa48896 Cr-Commit-Position: refs/heads/master@{#41109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -30 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/memory-reducer.h View 4 chunks +12 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 6 chunks +29 lines, -11 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 9 chunks +51 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
ptal
4 years, 1 month ago (2016-11-18 13:20:29 UTC) #3
Michael Lippautz
lgtm
4 years, 1 month ago (2016-11-18 13:21:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507293004/1
4 years, 1 month ago (2016-11-18 13:22:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 13:49:58 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 13:50:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9f8ad002e06e0211ec02e9a206443bd8fa48896
Cr-Commit-Position: refs/heads/master@{#41109}

Powered by Google App Engine
This is Rietveld 408576698