Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2507293002:
Correct the check in LIKELY. (Closed)
DescriptionCorrect the check in LIKELY.
Per sdefresne in https://codereview.chromium.org/2473153003.
BUG=632441
R=dcheng@chromium.org, sdefresne@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/ad4cb83f4cdf1722bf611b842c16f50c2d60e58e
Patch Set 1 #
Messages
Total messages: 23 (12 generated)
palmer@chromium.org changed reviewers: + dcheng@chromium.org, sdefresne@chromium.org
PTAL; trivial. Thanks!
The CQ bit was checked by palmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by palmer@chromium.org
The CQ bit was checked by palmer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by palmer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by palmer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Message was sent while issue was closed.
Description was changed from ========== Correct the check in LIKELY. Per sdefresne in https://codereview.chromium.org/2473153003. BUG=632441 ========== to ========== Correct the check in LIKELY. Per sdefresne in https://codereview.chromium.org/2473153003. BUG=632441 R=dcheng@chromium.org, sdefresne@chromium.org Committed: https://crrev.com/ad4cb83f4cdf1722bf611b842c16f50c2d60e58e Cr-Commit-Position: refs/heads/master@{#433274} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad4cb83f4cdf1722bf611b842c16f50c2d60e58e Cr-Commit-Position: refs/heads/master@{#433274}
Message was sent while issue was closed.
Description was changed from ========== Correct the check in LIKELY. Per sdefresne in https://codereview.chromium.org/2473153003. BUG=632441 R=dcheng@chromium.org, sdefresne@chromium.org Committed: https://crrev.com/ad4cb83f4cdf1722bf611b842c16f50c2d60e58e Cr-Commit-Position: refs/heads/master@{#433274} ========== to ========== Correct the check in LIKELY. Per sdefresne in https://codereview.chromium.org/2473153003. BUG=632441 R=dcheng@chromium.org, sdefresne@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ad4cb83f4cdf1722bf611b842c16... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as ad4cb83f4cdf1722bf611b842c16f50c2d60e58e (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
