Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2507253004: Add factory class for CertificateReportingService and a new metrics provider. (Closed)

Created:
4 years, 1 month ago by meacer
Modified:
4 years ago
Reviewers:
Jialiu Lin, estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add factory class for CertificateReportingService and a new metrics provider. This is a follow up to https://codereview.chromium.org/2483003003/ It introduces a factory class to create and get a CertificateReportingService singleton. It also introduces a metrics provider class that currently doesn't do anything, but will send pending reports in follow up CLs. BUG=554323 Committed: https://crrev.com/e36abfc1f420bb18a9e3e1007bb0eb51eaefed8c Cr-Commit-Position: refs/heads/master@{#434741}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move classes to safe_browsing, estark comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/safe_browsing/certificate_reporting_service_factory.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/certificate_reporting_service_factory.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
meacer
estark: Follow up CL. This doesn't do anything other than adding boiler plate code, but ...
4 years, 1 month ago (2016-11-17 20:57:05 UTC) #4
estark
lgtm https://codereview.chromium.org/2507253004/diff/1/chrome/browser/ssl/certificate_reporting_metrics_provider.h File chrome/browser/ssl/certificate_reporting_metrics_provider.h (right): https://codereview.chromium.org/2507253004/diff/1/chrome/browser/ssl/certificate_reporting_metrics_provider.h#newcode12 chrome/browser/ssl/certificate_reporting_metrics_provider.h:12: // CertificateReportingMetricsProvider nit: wrapping looks weird
4 years, 1 month ago (2016-11-21 18:20:44 UTC) #5
meacer
jialiul: Another one. PTAL? https://codereview.chromium.org/2507253004/diff/1/chrome/browser/ssl/certificate_reporting_metrics_provider.h File chrome/browser/ssl/certificate_reporting_metrics_provider.h (right): https://codereview.chromium.org/2507253004/diff/1/chrome/browser/ssl/certificate_reporting_metrics_provider.h#newcode12 chrome/browser/ssl/certificate_reporting_metrics_provider.h:12: // CertificateReportingMetricsProvider On 2016/11/21 18:20:44, ...
4 years ago (2016-11-24 00:36:57 UTC) #9
Jialiu Lin
lgtm
4 years ago (2016-11-24 00:44:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507253004/60001
4 years ago (2016-11-28 18:26:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-11-28 22:36:56 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-28 22:41:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e36abfc1f420bb18a9e3e1007bb0eb51eaefed8c
Cr-Commit-Position: refs/heads/master@{#434741}

Powered by Google App Engine
This is Rietveld 408576698