Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2507253003: MD Settings: Add ImportDataDialog tests. (Closed)

Created:
4 years, 1 month ago by dpapad
Modified:
4 years, 1 month ago
Reviewers:
tommycli, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add ImportDataDialog tests. BUG=659259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/346403640ca91d217eef9108ee5b03c4acfd5839 Cr-Commit-Position: refs/heads/master@{#432941}

Patch Set 1 : Fix cros. #

Patch Set 2 : Nit. #

Patch Set 3 : Remove pref permission. #

Total comments: 2

Patch Set 4 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -7 lines) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/test/data/webui/settings/import_data_dialog_test.js View 1 2 3 1 chunk +201 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
dpapad
4 years, 1 month ago (2016-11-16 23:57:19 UTC) #7
tommycli
lgtm https://codereview.chromium.org/2507253003/diff/60001/chrome/test/data/webui/settings/import_data_dialog_test.js File chrome/test/data/webui/settings/import_data_dialog_test.js (right): https://codereview.chromium.org/2507253003/diff/60001/chrome/test/data/webui/settings/import_data_dialog_test.js#newcode57 chrome/test/data/webui/settings/import_data_dialog_test.js:57: }, { nit... isn't normally the second { ...
4 years, 1 month ago (2016-11-17 17:04:28 UTC) #9
dpapad
https://codereview.chromium.org/2507253003/diff/60001/chrome/test/data/webui/settings/import_data_dialog_test.js File chrome/test/data/webui/settings/import_data_dialog_test.js (right): https://codereview.chromium.org/2507253003/diff/60001/chrome/test/data/webui/settings/import_data_dialog_test.js#newcode57 chrome/test/data/webui/settings/import_data_dialog_test.js:57: }, { On 2016/11/17 at 17:04:28, tommycli wrote: > ...
4 years, 1 month ago (2016-11-17 18:29:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507253003/40002
4 years, 1 month ago (2016-11-17 18:29:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/307163)
4 years, 1 month ago (2016-11-17 18:41:01 UTC) #15
Dan Beam
prefs_util.cc lgtm
4 years, 1 month ago (2016-11-17 19:25:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507253003/40002
4 years, 1 month ago (2016-11-17 19:26:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507253003/40002
4 years, 1 month ago (2016-11-17 19:27:32 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:40002)
4 years, 1 month ago (2016-11-17 20:13:22 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:29:08 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/346403640ca91d217eef9108ee5b03c4acfd5839
Cr-Commit-Position: refs/heads/master@{#432941}

Powered by Google App Engine
This is Rietveld 408576698