content: Terminate early if the toolkit initialization fails.

content/browser/browser_main_runner.cc

Index: content/browser/browser_main_runner.cc
diff --git a/content/browser/browser_main_runner.cc b/content/browser/browser_main_runner.cc
index 1f644121a06df750f04f344d91ecb6128750cd38..45a232a878bced3704a330ae8cfee384bdc65243 100644
--- a/content/browser/browser_main_runner.cc
+++ b/content/browser/browser_main_runner.cc
@@ -84,7 +84,8 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
       main_loop_->EarlyInitialization();
 
       // Must happen before we try to use a message loop or display any UI.
-      main_loop_->InitializeToolkit();
+      if (!main_loop_->InitializeToolkit())
+        return 0;

[Daniel Erat, 2014/04/24 22:39:27]

this method is super-undocumented. is this used as the program's exit code on
unix? if so, you should probably return a positive number instead of 0 -- chrome
_did_ fail to start.

[sadrul, 2014/04/24 22:57:14]

Yep, looks like it.
Is there a convention for what the exit-code should be in this case? Or should I
just use any random positive number? In that case, any suggestion/preference?

[Daniel Erat, 2014/04/24 23:21:08]

there aren't any conventions, as far as i'm aware. it's pretty common to use 1
as a generic code for failure, so i'd recommend that here.

[sadrul, 2014/04/25 02:34:48]

Done.

 
       main_loop_->MainMessageLoopStart();