content: Terminate early if the toolkit initialization fails.

content/browser/browser_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_main_runner.h"
 
 #include "base/allocator/allocator_shim.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/leak_annotations.h"
@@ skipping 66 matching lines @@
       ole_initializer_.reset(new ui::ScopedOleInitializer);
 #endif  // OS_WIN
 
       main_loop_.reset(new BrowserMainLoop(parameters));
 
       main_loop_->Init();
 
       main_loop_->EarlyInitialization();
 
       // Must happen before we try to use a message loop or display any UI.
-      main_loop_->InitializeToolkit();
+      if (!main_loop_->InitializeToolkit())
+        return 0;

[Daniel Erat, 2014/04/24 22:39:27]

this method is super-undocumented. is this used as the program's exit code on
unix? if so, you should probably return a positive number instead of 0 -- chrome
_did_ fail to start.

[sadrul, 2014/04/24 22:57:14]

Yep, looks like it.
Is there a convention for what the exit-code should be in this case? Or should I
just use any random positive number? In that case, any suggestion/preference?

[Daniel Erat, 2014/04/24 23:21:08]

there aren't any conventions, as far as i'm aware. it's pretty common to use 1
as a generic code for failure, so i'd recommend that here.

[sadrul, 2014/04/25 02:34:48]

Done.

 
       main_loop_->MainMessageLoopStart();
 
 // WARNING: If we get a WM_ENDSESSION, objects created on the stack here
 // are NOT deleted. If you need something to run during WM_ENDSESSION add it
 // to browser_shutdown::Shutdown or BrowserProcess::EndSession.
 
 #if defined(OS_WIN) && !defined(NO_TCMALLOC)
       // When linking shared libraries, NO_TCMALLOC is defined, and dynamic
       // allocator selection is not supported.
@@ skipping 74 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(BrowserMainRunnerImpl);
 };
 
 // static
 BrowserMainRunner* BrowserMainRunner::Create() {
   return new BrowserMainRunnerImpl();
 }
 
 }  // namespace content