content/public/android/java/src/org/chromium/IsReadyToPayServiceCallback.aidl - Issue 2507223002: Implement IsReadyToPay handling

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/src/org/chromium/IsReadyToPayServiceCallback.aidl

Issue 2507223002: Implement IsReadyToPay handling (Closed)

Patch Set: Add separate exceptions + comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java ('K') | « content/public/android/java/src/org/chromium/IsReadyToPayService.aidl ('k') | content/public/android/java/src/org/chromium/payments_common.aidl » ('j') | content/public/android/java/src/org/chromium/payments_common.aidl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package org.chromium;

	6

	7 /**

	8 * Helper interface to report back whether the

	9 * payment app is ready for payment.

	10 */

	11 oneway interface IsReadyToPayServiceCallback {
	please use gerrit instead 2017/01/13 20:54:46 By the way, Android Studio is complaining about "o By the way, Android Studio is complaining about "oneway" on the interface definition. It thinks that "oneway" is allowed only on methods. Have you tested this to work? rwlbuis 2017/01/13 22:12:25 It is confusing, in an article I saw both ways are Show quoted text On 2017/01/13 20:54:46, rouslan wrote: > By the way, Android Studio is complaining about "oneway" on the interface > definition. It thinks that "oneway" is allowed only on methods. Have you tested > this to work? It is confusing, in an article I saw both ways are fine. But the actual documentation that I found is pretty vague. I get the same warning in Android Studio, so I'll verify first that putting oneway on the method works. rwlbuis 2017/01/17 20:00:35 Okay, basically adding it on the interface is as g Show quoted text On 2017/01/13 22:12:25, rwlbuis wrote: > On 2017/01/13 20:54:46, rouslan wrote: > > By the way, Android Studio is complaining about "oneway" on the interface > > definition. It thinks that "oneway" is allowed only on methods. Have you > tested > > this to work? > > It is confusing, in an article I saw both ways are fine. But the actual > documentation that I found is pretty vague. > > I get the same warning in Android Studio, so I'll verify first that putting > oneway on the method works. Okay, basically adding it on the interface is as good as not adding it at all. At least, the generated java is the same. When putting the oneway on the method the generated code is not the same. I changed my local BobPay to also put the oneway on the methods and it works fine.
	12 /**

	13 * Method to be called by the Service to indicate

	14 * whether the payment app is ready for payment.

	15 *

	16 * @param isReadyToPay Whether payment app is ready to pay.

	17 */

	18 void handleIsReadyToPay(boolean isReadyToPay);

	19 }

	20
	please use gerrit instead 2017/01/13 20:54:46 nit: no trailing newline nit: no trailing newline
OLD	NEW