Stop providing Physical Web metadata after Bluetooth is disabled

Stop providing Physical Web metadata after Bluetooth is disabled

When the user disables Bluetooth, the Physical Web feature stops scanning
for nearby URLs but retains information about URLs that have already been
discovered. With this change, the retained information will not be returned
when clients request the list of Physical Web URLs with Bluetooth disabled.

BUG=663566
Committed: https://crrev.com/1cd34bcefa6bb7d368bbc36564a83698641630bb
Cr-Commit-Position: refs/heads/master@{#435699}

[mattreynolds, 2016-11-17 00:54:44]

mattreynolds@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[mattreynolds, 2016-11-17 00:54:45]

Hi Olivier, PTAL

[Olivier, 2016-11-17 09:04:37]

https://codereview.chromium.org/2507213003/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/physical_web_scanner.mm (right):

https://codereview.chromium.org/2507213003/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/physical_web_scanner.mm:169: return [devices_
sortedArrayUsingComparator:^(id obj1, id obj2) {
Should we clear devices_ ?

[mattreynolds, 2016-11-18 00:03:25]

https://codereview.chromium.org/2507213003/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/physical_web_scanner.mm (right):

https://codereview.chromium.org/2507213003/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/physical_web_scanner.mm:169: return [devices_
sortedArrayUsingComparator:^(id obj1, id obj2) {
On 2016/11/17 09:04:36, Olivier Robin wrote:
> Should we clear devices_ ?

When onLostDetectionEnabled_==NO, I think we shouldn't remove from devices_. The
scanner already has logic to handle changes to the Bluetooth state.

When onLostDetectionEnabled_==YES, the current behavior is to remove the devices
if they haven't been seen for kLostThresholdSeconds. But, the OnLost check
doesn't get run when Bluetooth is disabled, so they won't be removed until the
next time Bluetooth is enabled.

IMO it would be best to use the same logic to remove devices regardless of the
Bluetooth state. To allow the OnLost check to remove them, the repeating timer
needs to run while Bluetooth is disabled. I modified the timer so it stops
itself when there are no more nearby URLs.

https://codereview.chromium.org/2507213003/diff/20001/ios/chrome/common/physi...
File ios/chrome/common/physical_web/physical_web_scanner.mm (left):

https://codereview.chromium.org/2507213003/diff/20001/ios/chrome/common/physi...
ios/chrome/common/physical_web/physical_web_scanner.mm:341: [self reallyStop];
This was a bug, calling [centralManager_ stopScan] with Bluetooth disabled is an
error and generates an API MISUSE log message.

[Olivier, 2016-11-18 08:13:25]

lgtm

[mattreynolds, 2016-12-01 20:15:45]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:16:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:25:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480623345350050,
"parent_rev": "3a230c8d78ec544ccd34146ab5cdfee11437eba3", "commit_rev":
"a1abae2594d7782f8cb484178ec719e4c011a4b2"}

[commit-bot: I haz the power, 2016-12-01 20:25:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 20:29:12]

Description was changed from

==========
Stop providing Physical Web metadata after Bluetooth is disabled

When the user disables Bluetooth, the Physical Web feature stops scanning
for nearby URLs but retains information about URLs that have already been
discovered. With this change, the retained information will not be returned
when clients request the list of Physical Web URLs with Bluetooth disabled.

BUG=663566
==========

to

==========
Stop providing Physical Web metadata after Bluetooth is disabled

When the user disables Bluetooth, the Physical Web feature stops scanning
for nearby URLs but retains information about URLs that have already been
discovered. With this change, the retained information will not be returned
when clients request the list of Physical Web URLs with Bluetooth disabled.

BUG=663566

Committed: https://crrev.com/1cd34bcefa6bb7d368bbc36564a83698641630bb
Cr-Commit-Position: refs/heads/master@{#435699}
==========

[commit-bot: I haz the power, 2016-12-01 20:29:13]

Patchset 2 (id:??) landed as
https://crrev.com/1cd34bcefa6bb7d368bbc36564a83698641630bb
Cr-Commit-Position: refs/heads/master@{#435699}