📰 Cleanup ContextMenuManager and add tests

chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp;
 
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.View.OnCreateContextMenuListener;
 
+import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
 import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
 import org.chromium.ui.mojom.WindowOpenDisposition;
 
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.Set;
-
 /**
  * Displays the title, thumbnail, and favicon of a most visited page. The item can be clicked, or
  * long-pressed to trigger a context menu with options to "open in new tab", "open in incognito
  * tab", or "remove".
  */
 public class MostVisitedItem implements OnCreateContextMenuListener, OnClickListener {
     /**
      * Interface for an object that handles callbacks from a MostVisitedItem.
      */
     public interface MostVisitedItemManager {
@@ skipping 134 matching lines @@
                     public void removeItem() {
                         mManager.removeMostVisitedItem(MostVisitedItem.this);
                     }
 
                     @Override
                     public String getUrl() {
                         return MostVisitedItem.this.getUrl();
                     }
 
                     @Override
-                    public Set<Integer> getSupportedMenuItems() {
-                        return new HashSet<>(Arrays.asList(ContextMenuManager.ID_OPEN_IN_NEW_WINDOW,
-                                ContextMenuManager.ID_OPEN_IN_NEW_TAB,
-                                ContextMenuManager.ID_OPEN_IN_INCOGNITO_TAB,
-                                ContextMenuManager.ID_REMOVE,
-                                ContextMenuManager.ID_SAVE_FOR_OFFLINE));
+                    public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
+                        return true;
                     }
                 });
     }
 
     @Override
     public void onClick(View v) {
         mManager.openMostVisitedItem(WindowOpenDisposition.CURRENT_TAB, MostVisitedItem.this);
     }
 }