src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2507143003: [ic] Pass globals' names to Runtime::kDeclareGlobals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2507143003: [ic] Pass globals' names to Runtime::kDeclareGlobals. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 688904099682310f13c1c2aa586dfc7a6e358ad0..be91b0b70b10504652c523ca25a2b51b8eb82045 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -3062,7 +3062,7 @@ void LCodeGen::DoContext(LContext* instr) {

void LCodeGen::DoDeclareGlobals(LDeclareGlobals* instr) {

DCHECK(ToRegister(instr->context()).is(rsi));

- __ Push(instr->hydrogen()->pairs());

+ __ Push(instr->hydrogen()->declarations());

__ Push(Smi::FromInt(instr->hydrogen()->flags()));

__ Push(instr->hydrogen()->feedback_vector());

CallRuntime(Runtime::kDeclareGlobals, instr);